Skip to content
This repository has been archived by the owner on Nov 6, 2020. It is now read-only.

Commit

Permalink
Bump vscode engine version to 1.12.0 (use withProgress) (#271)
Browse files Browse the repository at this point in the history
  • Loading branch information
Jeff Young authored Jun 30, 2017
1 parent aed6d2e commit 1742245
Show file tree
Hide file tree
Showing 3 changed files with 5 additions and 5 deletions.
4 changes: 2 additions & 2 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -28,9 +28,9 @@ With TFVC, the extension uses information about the current workspace to determi
**Note:** At this time, you will need to have a ***local*** TFVC workspace already available on your local machine. More information about the difference between the two types (and how to determine which one you're using) can be found [here](TFVC_README.md#what-is-the-difference-between-a-local-and-server-workspace-how-can-i-tell-which-one-im-working-with). The issue tracking support for Server workspaces is [here](https://github.com/Microsoft/vsts-vscode/issues/176).

## Installation
First, you will need to install [Visual Studio Code](https://code.visualstudio.com/download) `1.11.1` or later.
First, you will need to install [Visual Studio Code](https://code.visualstudio.com/download) `1.12.0` or later.

To install the extension with the latest version of Visual Studio Code (version 1.11.1 is the latest as of this writing), bring up the Visual Studio Code Command Palette (`F1`), type `install` and choose `Extensions: Install Extensions`. In the `Search Extensions in Marketplace` text box, type `team`. Find the `Visual Studio Team Services` extension published by *Microsoft* and click the `Install` button. Restart Visual Studio Code.
To install the extension with the latest version of Visual Studio Code (version 1.13.1 is the latest as of this writing), bring up the Visual Studio Code Command Palette (`F1`), type `install` and choose `Extensions: Install Extensions`. In the `Search Extensions in Marketplace` text box, type `team`. Find the `Visual Studio Team Services` extension published by *Microsoft* and click the `Install` button. Restart Visual Studio Code.

## Authentication
### Visual Studio Team Services
Expand Down
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@
"license": "SEE LICENSE IN LICENSE.txt",
"homepage": "https://github.com/Microsoft/vsts-vscode/blob/master/README.md",
"engines": {
"vscode": "^1.11.0"
"vscode": "^1.12.0"
},
"enableProposedApi": false,
"activationEvents": [
Expand Down
4 changes: 2 additions & 2 deletions src/tfvc/scm/model.ts
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
*--------------------------------------------------------------------------------------------*/
"use strict";

import { Uri, EventEmitter, Event, Disposable, window } from "vscode";
import { Uri, EventEmitter, Event, Disposable, ProgressLocation, window } from "vscode";
import { Telemetry } from "../../services/telemetry";
import { TfvcTelemetryEvents } from "../../helpers/constants";
import { TfvcRepository } from "../tfvcrepository";
Expand Down Expand Up @@ -91,7 +91,7 @@ export class Model implements Disposable {
}

private async run(fn: () => Promise<void>): Promise<void> {
return window.withScmProgress(async () => {
return window.withProgress({ location: ProgressLocation.SourceControl }, async () => {
if (fn) {
await fn();
} else {
Expand Down

0 comments on commit 1742245

Please sign in to comment.