This repository has been archived by the owner on Nov 6, 2020. It is now read-only.
Filter a couple more events #166
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
April 6, 2017 16:50
Filter team-extension.log and ensure we filter files that aren't under the repositoryRoot folder (VS Code user settings changes were not being filtered)
jpricket
reviewed
Apr 6, 2017
src/tfvc/scm/model.ts
Outdated
| //filterEvent should return false if an event is to be filtered | ||
| const onNonGitChange = filterEvent(onWorkspaceChange, (uri) => { | ||
| // Ignore files that aren't under this._repositoryRoot (e.g., settings.json) | ||
| const isSubFolder: boolean = uri.fsPath.normalize().startsWith(path.normalize(this._repositoryRoot)); |
There was a problem hiding this comment.
Can fsPath ever be undefined? we may want to guard against that here
jpricket
reviewed
Apr 6, 2017
| @@ -137,8 +137,6 @@ export class TfvcSCMProvider { | |||
| this._disposables.push(this.conflictsGroup); | |||
| this._disposables.push(this.includedGroup); | |||
| this._disposables.push(this.excludedGroup); | |||
|
|
|||
| this._model.onDidChange(this.onDidModelChange, this); | |||
There was a problem hiding this comment.
Was this intentional? how will onDidModelChange get called?
There was a problem hiding this comment.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.