Fix build break for IntelliJ EAP 2019.1 #2763
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
konjac
previously approved these changes
Feb 20, 2019
|
Build fail with new introduced dependency. ALERT: New dependencies introduced! |
wezhang
reviewed
Feb 25, 2019
| @@ -2,6 +2,6 @@ javaVersion=1.8 | |||
| org.gradle.jvmargs='-Duser.language=en' | |||
| sources=false | |||
| intellij_version=IC-LATEST-EAP-SNAPSHOT | |||
| dep_plugins=org.intellij.scala:2018.3.2 | |||
| dep_plugins=org.intellij.scala:2019.1.1 | |||
There was a problem hiding this comment.
Is it back compatible with 183? #Resolved
wezhang
reviewed
Feb 26, 2019
| @@ -346,7 +346,7 @@ | |||
| </change-notes> | |||
|
|
|||
| <!-- please see https://confluence.jetbrains.com/display/IDEADEV/Build+Number+Ranges for description --> | |||
| <idea-version since-build="182" until-build="182.*"/> | |||
| <idea-version since-build="191" until-build="191.*"/> | |||
There was a problem hiding this comment.
This change can be moved out into 191 EAP release build support patch. #Resolved
wezhang
changed the title
t-rufang
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
not required and not used anymore. Refer to intelliJ-community repo0.4.3but we only upgrade it to0.4.2due to Cannot download JetBrains Java Runtime issue