Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove pindown for WinGet modules #2794

Merged
merged 3 commits into from
Nov 1, 2024

Conversation

janegilring
Copy link
Contributor

This pull request includes updates to the WinGet.ps1 scripts for both the ArcBox and HCIBox setups. The main changes involve the installation of WinGet PowerShell modules, where specific version constraints have been removed.

Changes to WinGet.ps1 scripts:

  • Removed the version constraints for the Microsoft.WinGet.Client and Microsoft.WinGet.DSC modules in azure_jumpstart_arcbox/artifacts/WinGet.ps1.
  • Removed the version constraints for the Microsoft.WinGet.Client and Microsoft.WinGet.DSC modules in azure_jumpstart_hcibox/artifacts/PowerShell/WinGet.ps1.

Fixes #2793

Signed-off-by: Jan Egil Ring <janegilring@microsoft.com>
@janegilring janegilring self-assigned this Oct 30, 2024
@janegilring janegilring added ArcBox Jumpstart ArcBox related HCIBox Jumpstart HCIBox related labels Oct 30, 2024
@janegilring janegilring added this to the October 2024 milestone Oct 30, 2024
@janegilring
Copy link
Contributor Author

Need to hold off merging until microsoft/winget-cli#4919 is resolved

dkirby-ms
dkirby-ms previously approved these changes Oct 31, 2024
@dkirby-ms dkirby-ms dismissed their stale review October 31, 2024 21:29

openissue

Signed-off-by: Jan Egil Ring <janegilring@microsoft.com>
Signed-off-by: Jan Egil Ring <janegilring@microsoft.com>
@janegilring
Copy link
Contributor Author

@dkirby-ms Upstream issue is resolved and this PR is ready to be merged.

Copy link
Contributor

@likamrat likamrat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@janegilring janegilring merged commit c4e0037 into microsoft:main Nov 1, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ArcBox Jumpstart ArcBox related HCIBox Jumpstart HCIBox related
Projects
Development

Successfully merging this pull request may close these issues.

Remove WinGet pindown for ArcBox and HCIBox
3 participants