Submitted a new extension to the gallery #14926
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The extension submitted is "SQL Data Inspector" (sql-data-inspector).
|
|
Charles-Gagnon
requested changes
Mar 31, 2021
There was a problem hiding this comment.
Could you please :
- Add this to the insiders gallery as well
- Add a
Microsoft.AzDataEngineproperty next to theMicrosoft.VisualStudio.Code.Engineproperty (it can still be * since it doesn't look like you have any dependency on a specific version of ADS, but you should still have one regardless)
Added Microsoft.AzDataEngine property to the extension sql-data-inspector.
Charles-Gagnon
approved these changes
Mar 31, 2021
There was a problem hiding this comment.
Played around with it a bit and didn't see any major issues, @alanrenmsft this look good to you?
Charles-Gagnon
approved these changes
Apr 2, 2021
alanrenmsft
approved these changes
Apr 6, 2021
alanrenmsft
reviewed
Apr 6, 2021
kburtram
approved these changes
Apr 8, 2021
Charles-Gagnon
approved these changes
Apr 8, 2021
|
@ernstc The gallery has been updated, thank you for your contribution! |
abist
pushed a commit
that referenced
this pull request
Apr 13, 2021
* Update Arc & Azdata extensions - Insiders (#14990) * Validate galleries for RC1 branch as well (#14994) * Update to extensions gallery json with upcoming language pack update (#14924) * Revert "Update to extensions gallery json with upcoming language pack update (#14924)" (#15032) This reverts commit bea6526. * Update azdata to latest - insiders (#15034) * Update CODEOWNERS (#15038) DRI * Update Kusto to 0.5.2 (#14959) * Updated Kusto version to 0.5.2. * Updated minimum AzDataEngine version * Update version of schema visualization (#15051) * Submitted a new extension to the gallery (#14926) * Submitted a new extension to the gallery The extension submitted is "SQL Data Inspector" (sql-data-inspector). * Fixed TotalCount in the extensions gallery. * Added extension sql-data-inspector to the insider gallery. Added Microsoft.AzDataEngine property to the extension sql-data-inspector. * Updated version for extension "sql-data-inspector" to v0.1.1. * Changed extension description and updated version to "0.1.2" Co-authored-by: Alex Ma <alma1@microsoft.com> Co-authored-by: Aditya Bist <adbist@microsoft.com> Co-authored-by: Justin M <63619224+JustinMDotNet@users.noreply.github.com> Co-authored-by: Jens Hunt <himself@jenshunt.se> Co-authored-by: Ernesto Cianciotta <ernesto.cianciotta@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The extension submitted is "SQL Data Inspector" (sql-data-inspector).
This PR fixes #