Update zone.js #18093
Merged
Update zone.js #18093
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 1699876689
💛 - Coveralls |
alanrenmsft
approved these changes
Jan 15, 2022
zijchen
pushed a commit
that referenced
this pull request
Jan 26, 2022
* Update zone.js * Update remote too
zijchen
pushed a commit
that referenced
this pull request
Feb 4, 2022
* Update zone.js * Update remote too
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #18084
Fixes #18047
The core issue here is that older versions of zone.js don't support the newer Node runtimes (see stephanrauh/ngx-extended-pdf-viewer#263 for a similar issue) that introduced things like Promise.allSettled.
In order to fix that we need to update to zone.js 10+, but this needed additional work since zone.js moved to support UMD in the newer versions which causes the
Can only have one anonymous define call per script filewe've seen with other modules. (documented here)This one was a bit different than the previous ones though since we were loading it directly using the Node require, so adding it to the list of amd modules didn't work (that path wasn't hit for native node module loading). I tried to get it to work with using import instead to force it through the VS Code/ADS normal module load path but was hitting other issues with then getting window.Zone to be defined correctly. So instead we just temporarily set amd to false so that zone.js loads as commonjs instead and then set it back right after. Not ideal but this was one of the things suggested by the VS Code dev I was talking to so should be safe enough for a (hopefully) one-off thing.