Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Run all npm commands async #894

Merged
merged 1 commit into from
Jul 13, 2023
Merged

Run all npm commands async #894

merged 1 commit into from
Jul 13, 2023

Conversation

ecraig12345
Copy link
Member

@ecraig12345 ecraig12345 commented Jul 13, 2023 •
edited
Loading

Remove the synchronous npm helper, and rename npmAsync to just npm. This is mainly to simplify some things in future tests.

Also remove some tests in packagePublish that were actually just verifying that the correct options were passed to npm publish, which is now covered by the getNpmPublishArgs tests.

(Most of the extra changes were triggered by updates to the npmShow test helper to make it asynchronous and tweak the signature.)

@ecraig12345 ecraig12345 merged commit 1f5136d into master Jul 13, 2023
4 checks passed
@ecraig12345 ecraig12345 deleted the ecraig/npm-async branch July 13, 2023 02:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@ecraig12345