Pass packageInfos into prepublish, postpublish, and postbump hooks #900
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tronguye
changed the title
tronguye
commented
Jul 21, 2023
| await hook(path.dirname(packageInfo.packageJsonPath), packageInfo.name, packageInfo.version); | ||
| const packagePath = path.dirname(packageInfo.packageJsonPath); | ||
|
|
||
| await hook(packagePath, packageInfo.name, packageInfo.version, packageInfos); |
There was a problem hiding this comment.
@ecraig12345 Should we clone package infos before passing? We're susceptible to side effects by hooks in the current calling pattern
There was a problem hiding this comment.
Marked param as Readonly<> in the typing of hooks. Doesn't technically stop a consumer from casting as writable and causing side effects. lmk what you think
ecraig12345
approved these changes
Jul 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Same end goal as #896
We are trying to have our yarn 1 repo be able to:
Locally, refer to local workspace package version using the * version
At publish time, change to ^x.y.z, where x.y.z is the post-bump version
To accomplish this, we are hoping to use the prepublish hook to change the internal packages to ^x.y.z. Passing the post-bump versions to the prepublish hook would allow for this to happen without file i/o on our end