Skip to content

Commit

Permalink
Update test baselines.
Browse files Browse the repository at this point in the history
  • Loading branch information
@michaelcfanning
michaelcfanning committed Feb 22, 2021
1 parent 2800141 commit 62c7d0f
Show file tree
Hide file tree
Showing 94 changed files with 816 additions and 768 deletions.
4 changes: 2 additions & 2 deletions src/BinSkim.Rules/PERules/BA2006.BuildWithSecureTools.cs
View file
Original file line number Diff line number Diff line change
Expand Up @@ -37,10 +37,8 @@ public class BuildWithSecureTools : WindowsBinaryAndPdbSkimmerBase, IOptionsProv

protected override IEnumerable<string> MessageResourceNames => new string[] {
nameof(RuleResources.BA2006_Error),
nameof(RuleResources.BA2006_Error_OutdatedCsc),
nameof(RuleResources.BA2006_Error_BadModule),
nameof(RuleResources.BA2006_Pass),
nameof(RuleResources.BA2006_Pass_Csc),
nameof(RuleResources.NotApplicable_InvalidMetadata)};

public IEnumerable<IOption> GetOptions()
Expand Down Expand Up @@ -86,10 +84,12 @@ public override void AnalyzePortableExecutableAndPdb(BinaryAnalyzerContext conte
PEBinary target = context.PEBinary();
Pdb pdb = target.Pdb;

/*
if (target.PE.IsManaged && !target.PE.IsMixedMode)
{
AnalyzeManagedPE(context);
}
*/

Version minCompilerVersion = new Version(int.MaxValue, int.MaxValue);

Expand Down
7 changes: 4 additions & 3 deletions ...st.FunctionalTests.BinSkim.Driver/BaselineTestsData/Expected/BinSkim.win-x64.ni.dll.sarif
View file
Original file line number Diff line number Diff line change
Expand Up @@ -594,8 +594,6 @@
"tool": {
"driver": {
"name": "testhost",
"organization": "Microsoft Corporation",
"product": "Microsoft.TestHost",
"version": "15.0.0.0",
"rules": [
{
Expand Down Expand Up @@ -1283,7 +1281,10 @@
},
"name": "SignSecurely"
}
]
],
"properties": {
"Comments": "A security and correctness analyzer for portable executable and MSIL formats."
}
}
},
"invocations": [
Expand Down
7 changes: 4 additions & 3 deletions ...st.FunctionalTests.BinSkim.Driver/BaselineTestsData/Expected/BinSkim.win-x86.ni.dll.sarif
View file
Original file line number Diff line number Diff line change
Expand Up @@ -592,8 +592,6 @@
"tool": {
"driver": {
"name": "testhost",
"organization": "Microsoft Corporation",
"product": "Microsoft.TestHost",
"version": "15.0.0.0",
"rules": [
{
Expand Down Expand Up @@ -1281,7 +1279,10 @@
},
"name": "SignSecurely"
}
]
],
"properties": {
"Comments": "A security and correctness analyzer for portable executable and MSIL formats."
}
}
},
"invocations": [
Expand Down
9 changes: 5 additions & 4 deletions ...est.FunctionalTests.BinSkim.Driver/BaselineTestsData/Expected/Binskim.linux-x64.dll.sarif
View file
Original file line number Diff line number Diff line change
Expand Up @@ -576,8 +576,6 @@
"tool": {
"driver": {
"name": "testhost",
"organization": "Microsoft Corporation",
"product": "Microsoft.TestHost",
"version": "15.0.0.0",
"rules": [
{
Expand Down Expand Up @@ -1237,7 +1235,10 @@
},
"name": "SignSecurely"
}
]
],
"properties": {
"Comments": "A security and correctness analyzer for portable executable and MSIL formats."
}
}
},
"invocations": [
Expand All @@ -1254,7 +1255,7 @@
}
],
"message": {
"text": "'Binskim.linux-x64.dll' was not evaluated for check 'EnableSecureSourceCodeHashing' because its PDB could not be loaded."
"text": "'Binskim.linux-x64.dll' was not evaluated for check 'EnableSecureSourceCodeHashing' because its PDB could not be loaded (E_PDB_NOT_FOUND)."
},
"level": "error",
"descriptor": {
Expand Down
7 changes: 4 additions & 3 deletions ...t.FunctionalTests.BinSkim.Driver/BaselineTestsData/Expected/Binskim.win-x64.RTR.dll.sarif
View file
Original file line number Diff line number Diff line change
Expand Up @@ -594,8 +594,6 @@
"tool": {
"driver": {
"name": "testhost",
"organization": "Microsoft Corporation",
"product": "Microsoft.TestHost",
"version": "15.0.0.0",
"rules": [
{
Expand Down Expand Up @@ -1283,7 +1281,10 @@
},
"name": "SignSecurely"
}
]
],
"properties": {
"Comments": "A security and correctness analyzer for portable executable and MSIL formats."
}
}
},
"invocations": [
Expand Down
9 changes: 5 additions & 4 deletions src/Test.FunctionalTests.BinSkim.Driver/BaselineTestsData/Expected/Binskim.win-x64.dll.sarif
View file
Original file line number Diff line number Diff line change
Expand Up @@ -576,8 +576,6 @@
"tool": {
"driver": {
"name": "testhost",
"organization": "Microsoft Corporation",
"product": "Microsoft.TestHost",
"version": "15.0.0.0",
"rules": [
{
Expand Down Expand Up @@ -1237,7 +1235,10 @@
},
"name": "SignSecurely"
}
]
],
"properties": {
"Comments": "A security and correctness analyzer for portable executable and MSIL formats."
}
}
},
"invocations": [
Expand All @@ -1254,7 +1255,7 @@
}
],
"message": {
"text": "'Binskim.win-x64.dll' was not evaluated for check 'EnableSecureSourceCodeHashing' because its PDB could not be loaded."
"text": "'Binskim.win-x64.dll' was not evaluated for check 'EnableSecureSourceCodeHashing' because its PDB could not be loaded (E_PDB_NOT_FOUND)."
},
"level": "error",
"descriptor": {
Expand Down
7 changes: 4 additions & 3 deletions ...t.FunctionalTests.BinSkim.Driver/BaselineTestsData/Expected/Binskim.win-x86.RTR.dll.sarif
View file
Original file line number Diff line number Diff line change
Expand Up @@ -592,8 +592,6 @@
"tool": {
"driver": {
"name": "testhost",
"organization": "Microsoft Corporation",
"product": "Microsoft.TestHost",
"version": "15.0.0.0",
"rules": [
{
Expand Down Expand Up @@ -1281,7 +1279,10 @@
},
"name": "SignSecurely"
}
]
],
"properties": {
"Comments": "A security and correctness analyzer for portable executable and MSIL formats."
}
}
},
"invocations": [
Expand Down
9 changes: 5 additions & 4 deletions src/Test.FunctionalTests.BinSkim.Driver/BaselineTestsData/Expected/Binskim.win-x86.dll.sarif
View file
Original file line number Diff line number Diff line change
Expand Up @@ -572,8 +572,6 @@
"tool": {
"driver": {
"name": "testhost",
"organization": "Microsoft Corporation",
"product": "Microsoft.TestHost",
"version": "15.0.0.0",
"rules": [
{
Expand Down Expand Up @@ -1233,7 +1231,10 @@
},
"name": "SignSecurely"
}
]
],
"properties": {
"Comments": "A security and correctness analyzer for portable executable and MSIL formats."
}
}
},
"invocations": [
Expand All @@ -1250,7 +1251,7 @@
}
],
"message": {
"text": "'Binskim.win-x86.dll' was not evaluated for check 'EnableSecureSourceCodeHashing' because its PDB could not be loaded."
"text": "'Binskim.win-x86.dll' was not evaluated for check 'EnableSecureSourceCodeHashing' because its PDB could not be loaded (E_PDB_NOT_FOUND)."
},
"level": "error",
"descriptor": {
Expand Down
5 changes: 3 additions & 2 deletions ...s.BinSkim.Driver/BaselineTestsData/Expected/Corrupted_Native_x86_VS2013_Default.exe.sarif
View file
Original file line number Diff line number Diff line change
Expand Up @@ -7,9 +7,10 @@
"tool": {
"driver": {
"name": "testhost",
"organization": "Microsoft Corporation",
"product": "Microsoft.TestHost",
"version": "15.0.0.0",
"properties": {
"Comments": "A security and correctness analyzer for portable executable and MSIL formats."
}
}
},
"invocations": [
Expand Down
7 changes: 4 additions & 3 deletions ...nSkim.Driver/BaselineTestsData/Expected/DotNetCore_RTR_linux-x64_VS2019_Default.dll.sarif
View file
Original file line number Diff line number Diff line change
Expand Up @@ -599,8 +599,6 @@
"tool": {
"driver": {
"name": "testhost",
"organization": "Microsoft Corporation",
"product": "Microsoft.TestHost",
"version": "15.0.0.0",
"rules": [
{
Expand Down Expand Up @@ -1288,7 +1286,10 @@
},
"name": "SignSecurely"
}
]
],
"properties": {
"Comments": "A security and correctness analyzer for portable executable and MSIL formats."
}
}
},
"invocations": [
Expand Down
7 changes: 4 additions & 3 deletions ...BinSkim.Driver/BaselineTestsData/Expected/DotNetCore_RTR_win-x64_VS2019_Default.dll.sarif
View file
Original file line number Diff line number Diff line change
Expand Up @@ -599,8 +599,6 @@
"tool": {
"driver": {
"name": "testhost",
"organization": "Microsoft Corporation",
"product": "Microsoft.TestHost",
"version": "15.0.0.0",
"rules": [
{
Expand Down Expand Up @@ -1288,7 +1286,10 @@
},
"name": "SignSecurely"
}
]
],
"properties": {
"Comments": "A security and correctness analyzer for portable executable and MSIL formats."
}
}
},
"invocations": [
Expand Down
7 changes: 4 additions & 3 deletions ...BinSkim.Driver/BaselineTestsData/Expected/DotNetCore_RTR_win-x86_VS2019_Default.dll.sarif
View file
Original file line number Diff line number Diff line change
Expand Up @@ -595,8 +595,6 @@
"tool": {
"driver": {
"name": "testhost",
"organization": "Microsoft Corporation",
"product": "Microsoft.TestHost",
"version": "15.0.0.0",
"rules": [
{
Expand Down Expand Up @@ -1284,7 +1282,10 @@
},
"name": "SignSecurely"
}
]
],
"properties": {
"Comments": "A security and correctness analyzer for portable executable and MSIL formats."
}
}
},
"invocations": [
Expand Down
7 changes: 4 additions & 3 deletions ...s.BinSkim.Driver/BaselineTestsData/Expected/DotNetCore_linux-x64_VS2019_Default.dll.sarif
View file
Original file line number Diff line number Diff line change
Expand Up @@ -599,8 +599,6 @@
"tool": {
"driver": {
"name": "testhost",
"organization": "Microsoft Corporation",
"product": "Microsoft.TestHost",
"version": "15.0.0.0",
"rules": [
{
Expand Down Expand Up @@ -1288,7 +1286,10 @@
},
"name": "SignSecurely"
}
]
],
"properties": {
"Comments": "A security and correctness analyzer for portable executable and MSIL formats."
}
}
},
"invocations": [
Expand Down
7 changes: 4 additions & 3 deletions ...sts.BinSkim.Driver/BaselineTestsData/Expected/DotNetCore_win-x64_VS2019_Default.dll.sarif
View file
Original file line number Diff line number Diff line change
Expand Up @@ -599,8 +599,6 @@
"tool": {
"driver": {
"name": "testhost",
"organization": "Microsoft Corporation",
"product": "Microsoft.TestHost",
"version": "15.0.0.0",
"rules": [
{
Expand Down Expand Up @@ -1288,7 +1286,10 @@
},
"name": "SignSecurely"
}
]
],
"properties": {
"Comments": "A security and correctness analyzer for portable executable and MSIL formats."
}
}
},
"invocations": [
Expand Down
7 changes: 4 additions & 3 deletions ...sts.BinSkim.Driver/BaselineTestsData/Expected/DotNetCore_win-x64_VS2019_Default.exe.sarif
View file
Original file line number Diff line number Diff line change
Expand Up @@ -590,8 +590,6 @@
"tool": {
"driver": {
"name": "testhost",
"organization": "Microsoft Corporation",
"product": "Microsoft.TestHost",
"version": "15.0.0.0",
"rules": [
{
Expand Down Expand Up @@ -1279,7 +1277,10 @@
},
"name": "SignSecurely"
}
]
],
"properties": {
"Comments": "A security and correctness analyzer for portable executable and MSIL formats."
}
}
},
"invocations": [
Expand Down
7 changes: 4 additions & 3 deletions ...sts.BinSkim.Driver/BaselineTestsData/Expected/DotNetCore_win-x86_VS2019_Default.dll.sarif
View file
Original file line number Diff line number Diff line change
Expand Up @@ -595,8 +595,6 @@
"tool": {
"driver": {
"name": "testhost",
"organization": "Microsoft Corporation",
"product": "Microsoft.TestHost",
"version": "15.0.0.0",
"rules": [
{
Expand Down Expand Up @@ -1284,7 +1282,10 @@
},
"name": "SignSecurely"
}
]
],
"properties": {
"Comments": "A security and correctness analyzer for portable executable and MSIL formats."
}
}
},
"invocations": [
Expand Down
9 changes: 5 additions & 4 deletions ...nSkim.Driver/BaselineTestsData/Expected/ManagedInteropAssemblyForAtlTestLibrary.dll.sarif
View file
Original file line number Diff line number Diff line change
Expand Up @@ -572,8 +572,6 @@
"tool": {
"driver": {
"name": "testhost",
"organization": "Microsoft Corporation",
"product": "Microsoft.TestHost",
"version": "15.0.0.0",
"rules": [
{
Expand Down Expand Up @@ -1233,7 +1231,10 @@
},
"name": "SignSecurely"
}
]
],
"properties": {
"Comments": "A security and correctness analyzer for portable executable and MSIL formats."
}
}
},
"invocations": [
Expand All @@ -1250,7 +1251,7 @@
}
],
"message": {
"text": "'ManagedInteropAssemblyForAtlTestLibrary.dll' was not evaluated for check 'EnableSecureSourceCodeHashing' because its PDB could not be loaded."
"text": "'ManagedInteropAssemblyForAtlTestLibrary.dll' was not evaluated for check 'EnableSecureSourceCodeHashing' because its PDB could not be loaded (E_PDB_NO_DEBUG_INFO)."
},
"level": "error",
"descriptor": {
Expand Down
Loading

0 comments on commit 62c7d0f

Please sign in to comment.