Correctly Trim Escaped Arguments

microsoft · Oct 17, 2024 · 8d31b06 · 8d31b06
1 parent e157372
commit 8d31b06
Showing 1 changed file with 4 additions and 3 deletions.
diff --git a/src/BinSkim.Driver/ExpandArguments.cs b/src/BinSkim.Driver/ExpandArguments.cs
@@ -20,13 +20,14 @@ public static string[] GenerateArguments(
 
             foreach (string argument in args)
             {
-                if (!IsResponseFileArgument(argument))
+                string trimArgument = argument.Trim('"');
+                if (!IsResponseFileArgument(trimArgument))
                 {
-                    expandedArguments.Add(argument);
+                    expandedArguments.Add(trimArgument);
                     continue;
                 }
 
-                string responseFile = argument.Trim('"').Substring(1);
+                string responseFile = trimArgument.Substring(1);
 
                 responseFile = environmentVariables.ExpandEnvironmentVariables(responseFile);
                 responseFile = fileSystem.PathGetFullPath(responseFile);