Add conditional check for TryGetPortablePdbMetadataReader when PDB file is missing
#1001
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
File.OpenRead can throw if pdb.PdbLocation is a directory. This can happen if (for some reason) the pdb file is not found. In which case PdbLocation will return the working directory, causing File.OpenRead to throw.
lukaskohl-msft
force-pushed
the
fix/pdbLocation-invalid
branch
from
66af743 to
81e1bc9
Compare
lukaskohl-msft
changed the title
FromPortablePdbStream inside PortableExecutable/PE.csTryGetPortablePdbMetadataReader when PDB file is missing
| @@ -16,6 +16,7 @@ | |||
| - NEW => new feature | |||
|
|
|||
| ## UNRELEASED | |||
| * BUG: Fix `TryGetPortablePdbMetadataReader` unexpectedly causes `UnauthorizedAccessException` error when the PDB file is missing. [1001](https://github.com/microsoft/binskim/pull/1001). | |||
| @@ -16,6 +16,7 @@ | |||
| - NEW => new feature | |||
|
|
|||
| ## UNRELEASED | |||
| * BUG: Fix `TryGetPortablePdbMetadataReader` unexpectedly causes `UnauthorizedAccessException` error when the PDB file is missing. [1001](https://github.com/microsoft/binskim/pull/1001). | |||
Adds a sample library that has been compiled as a standalone portable executable. The library doesn't have an accompanying pdb file, where prior to commit `81e1bc93` would make binskim throw on the working thread.
lukaskohl-msft
changed the base branch from
main
to
users/lukaskohl/pdblocation-invalid
lukaskohl-msft
merged commit b839fdd
into
microsoft:users/lukaskohl/pdblocation-invalid
3 of 4 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
File.OpenReadcan throw ifpdb.PdbLocationis a directory.This can happen if (for some reason) the pdb file is not found -- In which case
PdbLocationwill return the working directory, causingFile.OpenReadto throw.There's perhaps a better place to put this check, or a better way to handle this. Suggestions welcome :)
It would be great to have this scenario logged in some way, as there are
E_PDB_NOT_FOUNDorE_PDB_DBG_NOT_FOUNDHRESULT codes.For example:
C:\somePath\sni.dll : error ERR997.ExceptionLoadingPdb : 'sni.dll' was not evaluated because its PDB could not be loaded (E_PDB_NOT_FOUND).
However, I was unable to find a good way to integrate that into existing functionality, let me know if that's easily implementable.