Replace sarif-sdk submodule with Nuget package #1023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move from Submodule to NuGet
Overview
This pull request aims to migrate the BinSkim project from using the sarif-sdk submodule to a NuGet package. This change is intended to streamline the dependency management process and improve build reliability.
Changes
Removed the sarif-sdk submodule.
Added the sarif-sdk NuGet package to the project.
Updated the project files to reference the NuGet package instead of the submodule.
Benefits
Simplified Dependency Management: Using NuGet packages simplifies the process of managing dependencies, making it easier to update and maintain them.
Improved Build Reliability: By moving away from submodules, we reduce the potential for errors related to submodule synchronization and updates.
Testing
Verified that the project builds successfully with the new NuGet package.
Ran all existing tests to ensure no regressions were introduced.
Conducted manual testing to confirm that the functionality remains intact.
Additional Notes
If you encounter any issues or have questions about this migration, please feel free to reach out.