BUGFIX: Fix incorrect analysis for non-Microsoft compiler on BA2006.BuildWithSecureTools #545
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… check if fix works 2. now we can review the actual change without noise
shaopeng-gh
requested review from
eddynaka and
michaelcfanning
as code owners
eddynaka
reviewed
Jan 10, 2022
src/ReleaseHistory.md
Outdated
| @@ -2,6 +2,7 @@ | |||
|
|
|||
| ## Unreleased | |||
|
|
|||
| * BUGFIX: Fix Error BA2006: '...' was compiled with one or more modules which were not built using minimum required tool versions [545](https://github.com/microsoft/binskim/pull/545) | |||
There was a problem hiding this comment.
There was a problem hiding this comment.
agree, this is both short and clear.
shaopeng-gh
changed the title
michaelcfanning
deleted the
users/shaopeng-gh/skipunknown_cleanwithsdkmain
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note:
this is the same issue with #533,
The only difference is after we merged in SDK changes, this is now pointing to SDK main instead of private branch.
And then re-run the baseline. no new files changed.
And changed the history.md file with this new PR number "545"
Description:
reported issue with
error BA2006: '...' was compiled with one or more modules which were not built using minimum required tool versions
this error happens in new version 1.9.0
tested it passes in old version 1.7.2
Fix:
related to changeset #344
location: file BA2006.BuildWithSecureTools.cs line 104
we should add a skip if the compiler is not the ones we currently support those we can check min version.
After we widen the support we should remove this skip.