Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[c++] BT_STOP during a base deserialization confuses deserializer: can read unrelated struct's field as its own #742

Closed
chwarr opened this issue Dec 5, 2017 · 0 comments
Closed

[c++] BT_STOP during a base deserialization confuses deserializer: can read unrelated struct's field as its own #742

chwarr opened this issue Dec 5, 2017 · 0 comments
Assignees
@ara-ayvazyan
Labels
bug

Comments

@chwarr
Copy link
Member

chwarr commented Dec 5, 2017

During deserialization, BT_STOP and BT_STOP_BASE are treated identically when handling what is expected to be a base. This can cause deserialization to succeed with incorrect data when a deserialization failure is expected. I've adjusted one of the examples to demonstrate this failure in a branch on my fork.
@chwarr chwarr added the bug label Dec 5, 2017
@chwarr chwarr mentioned this issue Dec 5, 2017
Merged
@ara-ayvazyan ara-ayvazyan mentioned this issue Dec 8, 2017
Merged
chwarr pushed a commit that referenced this issue Dec 11, 2017
@ara-ayvazyan @chwarr
[c++] Fix base to derived deserialization
9ca99d4 
With this change deserialization will now fail by throwing `bond::CoreException` when `BT_STOP` is encountered while deserializing a base struct.

Fixes #742
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ara-ayvazyan ara-ayvazyan

Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@chwarr @ara-ayvazyan