Undo Bond.Runtime's limit to Newtonsoft.Json < 10 #230
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Bond.Runtime NuGet package again only specifies a lower bound on its Newtonsoft.JSON dependency. This reverts commit e2be0bf, which artificially limited the upper bound to < 10. The previous behavior did not limit Bond.Runtime to only working with Newtonsoft.Json 7.0.1. _However_, the default behavior of NuGet (since 2.8) is to install the _lowest_ version of a package that satisfied the constraints. This behavior can be overridden when a package is installed, but that decision needs to be made by the consumer of Bond.Runtime. Closes microsoft#212
|
This behavior of NuGet seems to be a poor choice and contrary to semantic versioning conventions. |
|
But wouldn't we want to keep a tighter control of what versions we support as a reliability factor? that is if we would have the proper tests for each major version. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Bond.Runtime NuGet package again only specifies a lower bound on its
Newtonsoft.JSON dependency. This reverts commit
e2be0bf, which artificially limited the
upper bound to < 10. The previous behavior did not limit Bond.Runtime to
only working with Newtonsoft.Json 7.0.1. However, the default behavior
of NuGet (since 2.8) is to install the lowest version of a package
that satisfied the constraints. This behavior can be overridden when a
package is installed, but that decision needs to be made by the consumer
of Bond.Runtime.
Closes #212