Extend bf utility to support multiple payloads #288
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chwarr
requested changes
Jan 5, 2017
| @@ -113,7 +113,7 @@ void TranscodeFromTo(Reader& reader, Writer& writer, const Options& options) | |||
| { | |||
| if (!options.schema.empty()) | |||
| { | |||
| bond::SchemaDef schema(LoadSchema(options.schema)); | |||
| bond::SchemaDef schema(LoadSchema(options.schema.front())); | |||
There was a problem hiding this comment.
This doesn't look like it handles an empty string like the old code used to.
Based on my reading and testing of boost::escaped_list_separator, which is used for the cmd arg parsing, it will return an empty string for the first item in an input like --schema=,second.schema.
| bf::Protocol from = options.from.empty() ? guess : options.from.front(); | ||
|
|
||
| if (from == guess) | ||
| std::cerr << std::endl << "Guessed " << ToString(from = Guess(input)) << std::endl; |
There was a problem hiding this comment.
Let's put the from = Guess(input) on its own line so we don't mix interesting logic with diagnostic output.
There was a problem hiding this comment.
It wasn't changed from the previous version. But you are right, it is cleaner when separate.
| if (!options.from.empty()) | ||
| options.from.pop_front(); | ||
| } | ||
| while (!options.schema.empty() || !options.from.empty()); |
There was a problem hiding this comment.
An extension, if you're interested, would be to have a way to specify that the last from/schema pair should be used to continually transcode until EOF.
There was a problem hiding this comment.
I like the idea but let me think about interface for this separately...
The `bf` C++ example is a handy utility to work with files containing
arbitrary Bond payloads. This change extends it to support files with
more than one Bond payload.
The most obvious use case is files with a sequence of records (e.g.
logs). The less obvious but very powerful scenario is extracting some
kind of header that precedes the actual Bond payload of interest. This
is possible because a Bond schema in Simple Binary protocol can be used
to model many kinds of arbitrary headers (e.g. any fixed size header
aligned to octet boundary).
The change is backward compatible and existing command line arguments
retain their old semantics. In order to process multiple payloads user
can specified multiple `--schema` and/or multiple `--from` arguments,
e.g.:
bf --from=simple --schema=header.json,payload.json file
In the above example `bf` will first use Simple Binary to decode header
in schema specified in `header.json` and then will try to guess the
protocol of the next payload (since only one `--from` argument was
specified) and decode it using schema specified by the `payload.json`
file.
Multiple values for the `--schema` and `--from` arguments can be
specified either as comma delimited values (like in the example above)
or by passing the argument multiple times, e.g.:
bf --from=fast --from=fast file
|
@chwarr, make the changes you requested. |
chwarr
approved these changes
Jan 9, 2017
jdubrule
pushed a commit
to jdubrule/bond
that referenced
this pull request
Jan 12, 2017
The `bf` C++ example is a handy utility to work with files containing
arbitrary Bond payloads. This change extends it to support files with
more than one Bond payload.
The most obvious use case is files with a sequence of records (e.g.
logs). The less obvious but very powerful scenario is extracting some
kind of header that precedes the actual Bond payload of interest. This
is possible because a Bond schema in Simple Binary protocol can be used
to model many kinds of arbitrary headers (e.g. any fixed size header
aligned to octet boundary).
The change is backward compatible and existing command line arguments
retain their old semantics. In order to process multiple payloads user
can specified multiple `--schema` and/or multiple `--from` arguments,
e.g.:
bf --from=simple --schema=header.json,payload.json file
In the above example `bf` will first use Simple Binary to decode header
in schema specified in `header.json` and then will try to guess the
protocol of the next payload (since only one `--from` argument was
specified) and decode it using schema specified by the `payload.json`
file.
Multiple values for the `--schema` and `--from` arguments can be
specified either as comma delimited values (like in the example above)
or by passing the argument multiple times, e.g.:
bf --from=fast --from=fast file
Closes microsoft#288
fuzhouch
pushed a commit
to fuzhouch/bond
that referenced
this pull request
Apr 9, 2017
The `bf` C++ example is a handy utility to work with files containing
arbitrary Bond payloads. This change extends it to support files with
more than one Bond payload.
The most obvious use case is files with a sequence of records (e.g.
logs). The less obvious but very powerful scenario is extracting some
kind of header that precedes the actual Bond payload of interest. This
is possible because a Bond schema in Simple Binary protocol can be used
to model many kinds of arbitrary headers (e.g. any fixed size header
aligned to octet boundary).
The change is backward compatible and existing command line arguments
retain their old semantics. In order to process multiple payloads user
can specified multiple `--schema` and/or multiple `--from` arguments,
e.g.:
bf --from=simple --schema=header.json,payload.json file
In the above example `bf` will first use Simple Binary to decode header
in schema specified in `header.json` and then will try to guess the
protocol of the next payload (since only one `--from` argument was
specified) and decode it using schema specified by the `payload.json`
file.
Multiple values for the `--schema` and `--from` arguments can be
specified either as comma delimited values (like in the example above)
or by passing the argument multiple times, e.g.:
bf --from=fast --from=fast file
Closes microsoft#288
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
bfC++ example is a handy utility to work with files containingarbitrary Bond payloads. This change extends it to support files with
more than one Bond payload.
The most obvious use case is files with a sequence of records (e.g.
logs). The less obvious but very powerful scenario is extracting some
kind of header that precedes the actual Bond payload of interest. This
is possible because a Bond schema in Simple Binary protocol can be used
to model many kinds of arbitrary headers (e.g. any fixed size header
aligned to octet boundary).
The change is backward compatible and existing command line arguments
retain their old semantics. In order to process multiple payloads user
can specified multiple
--schemaand/or multiple--fromarguments,e.g.:
In the above example
bfwill first use Simple Binary to decode headerin schema specified in
header.jsonand then will try to guess theprotocol of the next payload (since only one
--fromargument wasspecified) and decode it using schema specified by the
payload.jsonfile.
Multiple values for the
--schemaand--fromarguments can bespecified either as comma delimited values (like in the example above)
or by passing the argument multiple times, e.g.: