-
Notifications
You must be signed in to change notification settings - Fork 280
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ChannelAccount cannot accept extensible properties #4584
Labels
bug
Indicates an unexpected problem or an unintended behavior.
Comments
limamicro
added
bug
Indicates an unexpected problem or an unintended behavior.
needs-triage
The issue has just been created and it has not been reviewed by the team.
labels
Dec 14, 2023
tracyboehrer
removed
the
needs-triage
The issue has just been created and it has not been reviewed by the team.
label
Jan 26, 2024
tracyboehrer
pushed a commit
that referenced
this issue
Feb 13, 2024
This was referenced Jul 18, 2024
This was referenced Jul 28, 2024
This was referenced Sep 7, 2024
This was referenced Oct 30, 2024
This was referenced Nov 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Github issues should be used for bugs and feature requests. Use Stack Overflow for general "how-to" questions.
Versions
What package version of the SDK are you using. 4.21.3
What nodejs version are you using 8.19.4
What browser version are you using Teams T1
What os are you using Windows
Describe the bug
In ChannelAccount class, it should have an extensible property, so that it can accept optional properties which is not defined in class.
For example, in C#, we have
properties
act as JsonExtensionData.C# wiki link: ChannelAccount Class (Microsoft.Bot.Schema) | Microsoft Learn
Right now in JS, there is no existing way to accept optional properties.
JS wiki link: https://learn.microsoft.com/en-us/javascript/api/botframework-schema/channelaccount?view=botbuilder-ts-latest
JS SDK ChannelAccount class link:
botbuilder-js/libraries/botframework-schema/src/index.ts
Line 139 in f3db3e9
To Reproduce
Steps to reproduce the behavior:
await context.sendActivity({
text: 'Test Tag',
entities: [
{
type: 'mention',
text: 'Test Tag',
mentioned: {
id: tagId,
name: 'Test Tag',
type: 'tag'
}
}
]
});
Expected behavior
The client should receive a bot message with tag mention enabled.
Screenshots
Additional context
Add any other context about the problem here.
The text was updated successfully, but these errors were encountered: