Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make NuGet detector more conservative about applying isDevelopmentDependency #1314

Merged
merged 2 commits into from
Dec 4, 2024

Conversation

ericstj
Copy link
Member

@ericstj ericstj commented Nov 25, 2024

Most PackageDownloads will be used for runtime, so opt to treat these as non-development-dependencies.

For other packages, only consider them development dependencies when they don't contribute assets from any of the following categories: runtime, runtimeTargets, resource assemblies, native, content, build, build multitargeting, and analyzers.

…endency

Most PackageDownloads will be used for runtime, so opt to treat these as non-development-dependencies.

For other packages, only consider them development dependencies when they don't contribute assets from any of the following categories: runtime, runtimeTargets, resource assemblies, native, content, build, build multitargeting, and analyzers.
@ericstj ericstj requested review from zivkan and grvillic November 25, 2024 20:20
@ericstj ericstj requested a review from a team as a code owner November 25, 2024 20:20
Copy link

codecov bot commented Nov 25, 2024

Codecov Report

Attention: Patch coverage is 96.96970% with 1 line in your changes missing coverage. Please review.

Project coverage is 89.3%. Comparing base (9f24dfc) to head (a387e94).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
...get/NuGetPackageReferenceFrameworkAwareDetector.cs 95.6% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@          Coverage Diff          @@
##            main   #1314   +/-   ##
=====================================
  Coverage   89.3%   89.3%           
=====================================
  Files        387     387           
  Lines      30372   30387   +15     
  Branches    1868    1871    +3     
=====================================
+ Hits       27147   27161   +14     
  Misses      2827    2827           
- Partials     398     399    +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@grvillic grvillic merged commit 3c58d59 into microsoft:main Dec 4, 2024
20 of 23 checks passed
Copy link

github-actions bot commented Dec 4, 2024

👋 Hi! It looks like you modified some files in the Detectors folder.
You may need to bump the detector versions if any of the following scenarios apply:

  • The detector detects more or fewer components than before
  • The detector generates different parent/child graph relationships than before
  • The detector generates different devDependencies values than before

If none of the above scenarios apply, feel free to ignore this comment 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants