Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Experiments evaluation of new dep dependencies #1315

Merged
merged 3 commits into from
Dec 2, 2024

Conversation

grvillic
Copy link
Contributor

Context

As we were evaluating the .NET experiment for new detector, we noticed a bug in our experimental diffing evaluation. If a new dev dependency is introduced that is not reported in control group, it should still be reported as a dev dependency. As of now, that component only gets added to the AddedIds but it never gets flagged as dev dependency.

@grvillic grvillic requested a review from a team as a code owner November 28, 2024 03:21
@grvillic grvillic requested a review from annaowens November 28, 2024 03:21
Copy link

codecov bot commented Nov 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.3%. Comparing base (952c1ce) to head (9563f0c).
Report is 1 commits behind head on main.

Additional details and impacted files
@@          Coverage Diff          @@
##            main   #1315   +/-   ##
=====================================
  Coverage   89.3%   89.3%           
=====================================
  Files        379     379           
  Lines      30082   30108   +26     
  Branches    1840    1842    +2     
=====================================
+ Hits       26870   26895   +25     
  Misses      2821    2821           
- Partials     391     392    +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@grvillic grvillic enabled auto-merge (squash) December 2, 2024 17:08
@grvillic grvillic merged commit 218b693 into main Dec 2, 2024
21 of 24 checks passed
@grvillic grvillic deleted the users/grvillic/FixExperimentsForDevDeps branch December 2, 2024 17:12
Copy link

github-actions bot commented Dec 2, 2024

👋 Hi! It looks like you modified some files in the Detectors folder.
You may need to bump the detector versions if any of the following scenarios apply:

  • The detector detects more or fewer components than before
  • The detector generates different parent/child graph relationships than before
  • The detector generates different devDependencies values than before

If none of the above scenarios apply, feel free to ignore this comment 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants