Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Update syft image and doc - use docker commands" #1318

Merged
merged 1 commit into from
Dec 4, 2024

Conversation

pauld-msft
Copy link
Member

@pauld-msft pauld-msft commented Dec 4, 2024

Reverting so that some later changes (with lower risk) can be released separately. Will re-introduce later on

@pauld-msft pauld-msft requested a review from a team as a code owner December 4, 2024 14:19
Copy link

codecov bot commented Dec 4, 2024

Codecov Report

Attention: Patch coverage is 10.34483% with 26 lines in your changes missing coverage. Please review.

Project coverage is 89.7%. Comparing base (3c58d59) to head (e94161b).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...tDetection.Detectors/linux/Contracts/SyftOutput.cs 7.1% 26 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##            main   #1318     +/-   ##
=======================================
+ Coverage   89.3%   89.7%   +0.3%     
=======================================
  Files        387     387             
  Lines      30387   30271    -116     
  Branches    1871    1871             
=======================================
- Hits       27162   27160      -2     
+ Misses      2827    2713    -114     
  Partials     398     398             

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pauld-msft pauld-msft merged commit e7239ea into main Dec 4, 2024
22 of 26 checks passed
@pauld-msft pauld-msft deleted the revert-1307-pauldorsch/updatesyftdocs branch December 4, 2024 16:26
pauld-msft added a commit that referenced this pull request Dec 4, 2024
Copy link

github-actions bot commented Dec 4, 2024

👋 Hi! It looks like you modified some files in the Detectors folder.
You may need to bump the detector versions if any of the following scenarios apply:

  • The detector detects more or fewer components than before
  • The detector generates different parent/child graph relationships than before
  • The detector generates different devDependencies values than before

If none of the above scenarios apply, feel free to ignore this comment 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants