Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PR to populate disable detectors list #820

Merged
merged 2 commits into from
Sep 29, 2023

Conversation

Omotola
Copy link
Contributor

@Omotola Omotola commented Sep 28, 2023

Readded changes to populate disabled detectors list and added some unit tests. Also modified ScanResult contract to help with the unit tests.

@Omotola Omotola requested a review from a team as a code owner September 28, 2023 19:22
@Omotola Omotola requested a review from grvillic September 28, 2023 19:22
@codecov
Copy link

codecov bot commented Sep 28, 2023

Codecov Report

Merging #820 (a11076e) into main (f9bbd39) will decrease coverage by 0.26%.
Report is 1 commits behind head on main.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #820      +/-   ##
==========================================
- Coverage   75.84%   75.59%   -0.26%     
==========================================
  Files         240      240              
  Lines        9979    10018      +39     
==========================================
+ Hits         7569     7573       +4     
- Misses       2410     2445      +35     
Files Coverage Δ
...ponentDetection.Contracts/BcdeModels/ScanResult.cs 100.00% <100.00%> (ø)
...tion.Orchestrator/Services/ScanExecutionService.cs 91.83% <100.00%> (+0.53%) ⬆️

... and 1 file with indirect coverage changes

@Omotola Omotola merged commit 18ed6c4 into main Sep 29, 2023
22 of 25 checks passed
@Omotola Omotola deleted the users/oakeredolu/defaultdetectorfix branch September 29, 2023 01:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants