Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for GCC 4.7 (and VS2013) #609

Merged
merged 6 commits into from
Jan 24, 2018
Merged

Conversation

garethsb
Copy link
Contributor

Only a small number of changes are required to build C++ REST SDK for GCC 4.7. While this may not be an officially supported compiler, the changes in this PR are ultimately trivial, with little or no effect on currently supported versions of GCC and MSVC. Each commit contains the workaround for one issue, explained in the commit comment.

One of the workarounds is also applied for VS2013 which has a similar compiler bug.

…f a template argument list or *_cast conversion incorrectly as the digraph '<:' (meaning '[') followed by a single ':'; the former can be resolved by -fpermissive, the latter isn't
…4.9) that means std::this_thread::yield() and std::this_thread::sleep_for() are only conditionally provided; see https://stackoverflow.com/a/12961816
…ctors (and default specification on explicit destructors without exception specifications) aren't perfectly implemented
…captured for this lambda function" to be reported incorrectly
…ires the compiler to capture 'this' but the current default capture mode does not allow it"; the issue and workaround is the same as for GCC 4.7 in commit:5244af7c.
@msftclas
Copy link

msftclas commented Nov 23, 2017

CLA assistant check
All CLA requirements met.

@ras0219-msft
Copy link
Contributor

These all look good; I'll be happy to merge them once you've signed the CLA!

@garethsb
Copy link
Contributor Author

@ras0219-msft Hi Robert, I just received an early Christmas present, the go-ahead to sign the CLA! I would be very happy if you would be able to merge PRs #609, #611, #612 and #624, and I would welcome any feedback on PRs #630 and #565. Thanks again for your patience.

@ras0219-msft ras0219-msft merged commit 50e81a5 into microsoft:master Jan 24, 2018
@ras0219-msft
Copy link
Contributor

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants