Skip to content

Commit

Permalink
Merge pull request #227 from microsoft/v1.8.8-draft
Browse files Browse the repository at this point in the history
Addressing Issues in v.1.8.8
  • Loading branch information
prdpsvs authored Sep 11, 2024
2 parents 46bb72f + c376134 commit bc772ac
Show file tree
Hide file tree
Showing 3 changed files with 7 additions and 7 deletions.
6 changes: 3 additions & 3 deletions dbt/adapters/fabric/fabric_relation.py
Original file line number Diff line number Diff line change
Expand Up @@ -18,10 +18,10 @@ def get_relation_type(cls) -> Type[FabricRelationType]:

@classmethod
def render_limited(self) -> str:
rendered = self.render(self=self)
rendered = self.render()
if self.limit is None:
return rendered
elif self.limit == 0:
return f"(select * from {rendered} where 1=0) _dbt_top_subq"
return f"(select * from {rendered} where 1=0) {self._render_limited_alias()}"
else:
return f"(select TOP {self.limit} * from {rendered}) _dbt_top_subq"
return f"(select TOP {self.limit} * from {rendered}) {self._render_limited_alias()}"
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@

{% set columns %}
{% for column in columns %}
, CAST(NULL AS {{column.data_type}}) AS {{column_name}}
, CAST(NULL AS {{column.data_type}}) AS {{column.name}}
{% endfor %}
{% endset %}

Expand Down
6 changes: 3 additions & 3 deletions dev_requirements.txt
Original file line number Diff line number Diff line change
Expand Up @@ -6,10 +6,10 @@ git+https://github.com/dbt-labs/dbt-adapters.git#subdirectory=dbt-tests-adapter
git+https://github.com/dbt-labs/dbt-common.git

pytest==8.0.1
twine==5.0.0
wheel==0.42
twine==5.1.1
wheel==0.44.0
pre-commit==3.5.0;python_version<"3.9"
pre-commit==3.6.2;python_version>="3.9"
pre-commit==3.8.0;python_version>="3.9"
pytest-dotenv==0.5.2
flaky==3.7.0
pytest-xdist==3.5.0
Expand Down

0 comments on commit bc772ac

Please sign in to comment.