Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Store Failures flag will generate model w/o failure #234

Closed
TheBishop-98 opened this issue Oct 12, 2024 · 1 comment
Closed

Store Failures flag will generate model w/o failure #234

TheBishop-98 opened this issue Oct 12, 2024 · 1 comment

Comments

@TheBishop-98
Copy link

We are encountering an issue that the --store-failures flag will generate a model even when the test passes. All of my claims test tables are blanks when they should not be created because the tests passed?

Project yaml:

data_tests:
  HMA_DBT_ENTERPRISE:
    +store_failures_as: table
    +database: DataMarts 
    +schema: data_tests

Model yaml:

- name: company_id
  description: "{{ doc('acl_companyID')}}"
  data_tests:
    - relationships:
        to: ref('stg_ACL_COMPANIES')
        field: company_id
        config:
          severity: warn
  data_type: varchar(8000)

- name: line_of_coverage_id
  description: "{{ doc('acl_lineOfCoverageID')}}"
  data_tests:
    - relationships:
        to: ref('stg_ACL_LINES_OF_COVERAGE')
        field: line_of_coverage_id
        config:
          severity: warn
  data_type: varchar(8000)

Image
Image

@prdpsvs
Copy link
Collaborator

prdpsvs commented Dec 23, 2024

Models created in data tests are also used in reconciliation purposes as part of adapter integration tests. Fabric was extending this behavior. The latest PR #251 added test materialization. Data tests models are still created but deleted if no failures observed after executing data tests.

@prdpsvs prdpsvs closed this as completed Dec 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants