V1.8.8 draft #251
Merged
V1.8.8 draft #251
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…on correctly based on its type
This was referenced Dec 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes several updates to the configuration files and codebase to improve integration tests, connection management, and macro definitions.
Workflow Configuration Updates:
.github/workflows/integration-tests-azure.yml: Renamed the job and updated the profile and permissions for integration tests. Switched from Azure CLI login to Azure login with OIDC and added a step to test the connection to Fabric Data Warehouse. [1] [2].github/workflows/publish-docker.yml: Addedworkflow_dispatchtrigger and a step to list Docker images. [1] [2].github/workflows/unit-tests.yml: Limited Python versions to 3.10 and 3.11 for unit tests.Codebase Enhancements:
dbt/adapters/fabric/fabric_connection_manager.py: Added methods for handling access tokens and updated the connection string logic to include pooling and retry configurations. [1] [2] [3] [4] [5] [6]dbt/adapters/fabric/__version__.py: Bumped version to 1.8.9.dbt/adapters/fabric/fabric_credentials.py: Addedaccess_tokenattribute and updated default retry count.Macro Improvements:
dbt/include/fabric/macros/adapters/catalog.sql: Added database usage checks and improved join conditions. [1] [2] [3] [4] [5]dbt/include/fabric/macros/adapters/metadata.sql: Ensured database names are properly formatted.dbt/include/fabric/macros/adapters/schema.sql: Added database usage commands before dropping schemas.dbt/include/fabric/macros/adapters/show.sql: Improved SQL limit handling logic.dbt/include/fabric/macros/materializations/models/table/table.sql: Enhanced logic for creating backup relations.dbt/include/fabric/macros/materializations/snapshots/helpers.sql: Simplified column creation logic.dbt/include/fabric/macros/materializations/snapshots/snapshot.sql: Improved handling of temporary views in snapshots.These changes collectively enhance the integration testing setup, streamline connection management, and improve the reliability and clarity of macro definitions.