Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v1.8.0rc1 #127

Merged
merged 11 commits into from
Feb 27, 2024
Merged

v1.8.0rc1 #127

merged 11 commits into from
Feb 27, 2024

Conversation

nszoni
Copy link
Contributor

@nszoni nszoni commented Feb 23, 2024

Features

Supporting dbt-core 1.8.0

Bug fixes

This change allows us to run our integration tests but from occasionally there are still locks.

E pyodbc.ProgrammingError: ('42000', "[42000] [Microsoft][ODBC Driver 18 for SQL Server][SQL Server]Snapshot isolation transaction failed in database 'dbtfabricadapter' because the object accessed by the statement has been modified by a DDL statement in another concurrent transaction since the start of this transaction.  It is disallowed because the metadata is not versioned. A concurrent update to metadata can lead to inconsistency if mixed with snapshot isolation. (3961) (SQLExecDirectW)")

Fabric only support Snapshot isolation level, so the "trick" of turning off and on again is not going to work i think...

couple refs:

TLDR, for Fabric we have a limitation of having only one isolation level which imo can't be changed, nor switched off with SET TRANSACTION hints so at this point i see no workaround until Fabric starts to support other isolation types.

Enhancements

Decouple imports to common dbt core and dbt adapter interface packages for future maintainability and extensibility.

  • Bump adapter packages
    • from pyodbc>=4.0.35,<5.1.0" to pyodbc>=4.0.35,<5.2.0

From now on, Apple-silicon users don't have to locally build pyodbc, because M1, M2 binaries is included in pyodbc from 5.1.0 onwards!

  • Bump dev requirements
    • from pytest~=7.4. to pytest~=8.0.1
    • from twine~=4.0.2 to twine~=5.0.0
    • from pre-commit~=3.5.0 to pre-commit~=3.6.2

@nszoni nszoni requested a review from prdpsvs February 26, 2024 09:29
@nszoni nszoni marked this pull request as ready for review February 26, 2024 09:29
@prdpsvs prdpsvs merged commit 8639a0a into main Feb 27, 2024
17 checks passed
@arthurcht arthurcht deleted the v1.8_dataroots branch March 1, 2024 10:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants