Updating dispatching methods to ensure dbt-synapse adapter can use ad… #178
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jtcohen6
reviewed
May 22, 2024
dbt/include/fabric/macros/materializations/models/view/view.sql
Outdated
Show resolved
Hide resolved
…ving it from adapter create_table_as.sql macro
jtcohen6
reviewed
May 30, 2024
There was a problem hiding this comment.
Nice work @prdpsvs!
I left some comments around code style.
I'd also recommend that you update microsoft/dbt-synapse#245 to pull in these changes, and verify that the tests now pass on Synapse.
dbt/include/fabric/macros/materializations/models/incremental/incremental.sql
Outdated
Show resolved
Hide resolved
dbt/include/fabric/macros/materializations/models/table/columns_spec_ddl.sql
Outdated
Show resolved
Hide resolved
dbt/include/fabric/macros/materializations/models/table/columns_spec_ddl.sql
Outdated
Show resolved
Hide resolved
Co-authored-by: Jeremy Cohen <jeremy@fishtownanalytics.com>
…incremental.sql Co-authored-by: Jeremy Cohen <jeremy@fishtownanalytics.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…apter dispatch methods