feat: add returnValue as a Scope.presentationHint #484
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
roblourens
approved these changes
Jun 28, 2024
| "enumDescriptions": [ | ||
| "Scope contains method arguments.", | ||
| "Scope contains local variables.", | ||
| "Scope contains registers. Only a single `registers` scope should be returned from a `scopes` request." | ||
| "Scope contains registers. Only a single `registers` scope should be returned from a `scopes` request.", | ||
| "Scope contains a return value. A scope of this kind should have a single child variable." |
There was a problem hiding this comment.
I don't think the second part of the description makes sense -- there could be multiple return values active. Example:
If you step over:
A().B().C();
The C# and Microsoft C++ debugger will capture a return value from all three functions.
There was a problem hiding this comment.
Good point, will remove that wording
connor4312
added a commit
that referenced
this pull request
Jul 1, 2024
Following up a comment on #484
connor4312
added a commit
that referenced
this pull request
Jul 1, 2024
Following up a comment on #484
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #458