Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"presentationHint" is not set for variable scopes #236

Closed
int19h opened this issue May 11, 2020 · 3 comments
Closed

"presentationHint" is not set for variable scopes #236

int19h opened this issue May 11, 2020 · 3 comments
Assignees
Labels
bug Something isn't working

Comments

@int19h
Copy link
Contributor

int19h commented May 11, 2020

DAP Scope interface defines presentationHint for the purposes of distinguishing standard scope (locals, globals etc). Visual Studio uses this to determine whether the scope is locals or not, to inline locals into the top level. However, pydevd does not set presentationHint for any of the scopes - only the label.

@fabioz
Copy link
Collaborator

fabioz commented May 13, 2020

Just to confirm:

From the docs it seems that the values available for presentationHint are: arguments, locals and registers.

So, the fix to this issue is just passing locals to the 'Locals' scope or should it also pass locals to the Globals scope?

@fabioz
Copy link
Collaborator

fabioz commented May 13, 2020

(or does VS accept something as globals there, even not being in the spec?)

@int19h
Copy link
Contributor Author

int19h commented May 13, 2020

Just "Locals". What we want is for that group to be auto-inlined into the parent (i.e. all variables to show as top level) in VS. It might also do this in VSCode - if so, that's fine.

fabioz added a commit to fabioz/debugpy that referenced this issue May 13, 2020
@fabioz fabioz closed this as completed in f752952 May 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants