Native thread tracing in frame eval mode / disable qt monkeypatching by default. #452
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Kudos, SonarCloud Quality Gate passed!
|
|
Nice! Yes, the Qt change should be okay, since it would only apply to 2.7 and 3.5. |
int19h
approved these changes
Nov 3, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request does a few things:
It automatically creates a DummyThread for native threads and sets the tracing (called from the frame eval mode). This enables native threads to be traced by default when using the frame eval mode.
Disable the qt monkeypatching by default (it's still available to be used when frame eval is not available, but given that just importing qt seems to have side effects: Debugger times out when "qt":"auto" is used with ArcGIS Python #362, disabling by default is probably the proper thing to do anyways).
Use the internal version of the call tracing hook (this fixes the CPython issue: https://bugs.python.org/issue42197 for the debugger for all supported versions of CPython as the internal call tracing hook doesn't call the functions to update the locals) -- the debugger isn't as affected by this because it tries to not trace any context whenever possible, but when actually stepping or if the tracing must be kept on because exceptions are being tracked, this should be a noticeable performance improvement.