Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-enable frame eval mode by default. #878

Merged
merged 1 commit into from
Apr 7, 2022

Conversation

fabioz
Copy link
Collaborator

@fabioz fabioz commented Mar 24, 2022

It was disabled as temporary workaround in #346, but that was fixed and it appears it wasn't re-enabled...

@sonarcloud
Copy link

sonarcloud bot commented Apr 1, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@fabioz
Copy link
Collaborator Author

fabioz commented Apr 1, 2022

As a note, this change does seem to make the tests more prone to failure.

I tried analyzing those but I couldn't find out why that happens (it's possible that it's just timing differences in the test run).

It's weird that the failing tests appear to be some variation of:

2022-04-01T14:14:17.3234090Z   File "/Users/runner/work/1/s/.tox/py38/lib/python3.8/site-packages/debugpy/_vendored/pydevd/_pydevd_bundle/pydevd_comm.py", line 491, in start_client
2022-04-01T14:14:17.3234950Z     s.connect((host, port))
2022-04-01T14:14:17.3235520Z ConnectionRefusedError: [Errno 61] Connection refused

Meaning that the debugger is trying to connect to the client but it's not successful (and the change isn't related to that at all).

Also, failures seem to be tied mostly to MacOS.

@int19h int19h merged commit 1b568ab into microsoft:main Apr 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants