Add remote port parameter to TCP listener factory #104
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addresses a bug in the dev tunnels CLI / SDK: it can print the wrong remote port number for an IPv6 client connection endpoint when the original port number was in use.
In the example above, the IPv6 port 9001 is actually forwarding to host port 9000, the same as IPv4. The console output there is wrong. (This only happens if port 9000 was in use before the command was run.)
With the
remotePort
parameter added in this change, the dev tunnels SDK RetryTcpListenerFactory can be updated to use theremotePort
instead oflocalPort
in the message"Forwarding from {listener.LocalEndpoint} to host port {localPort}."
.Additionally, this can allow for a future capability for a tunnel client to map host port numbers to different arbitrary client port numbers.