Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Dev Diagnostics Experimental Feature #3955

Merged
merged 3 commits into from
Oct 28, 2024
Merged

Conversation

krschau
Copy link
Collaborator

@krschau krschau commented Oct 22, 2024

Summary of the pull request

References and relevant issues

Detailed description of the pull request / Additional comments

Validation steps performed

PR checklist

  • Closes #xxx
  • Tests added/passed
  • Documentation updated

@jaholme
Copy link
Contributor

jaholme commented Oct 22, 2024

  </Extensions>

This should also go as well. It was a part of Dev Diagnostics


Refers to: src/Package-Dev.appxmanifest:399 in 0c4e347. [](commit_id = 0c4e347, deletion_comment = False)

@jaholme
Copy link
Contributor

jaholme commented Oct 22, 2024

<ProjectReference Include="..\tools\Utilities\RegPreviewUtility\DevHome.RegistryPreview.csproj" />

this was a piece of devdiagnostics not utilties


Refers to: src/DevHome.csproj:108 in 0c4e347. [](commit_id = 0c4e347, deletion_comment = False)

@dabhattimsft
Copy link
Contributor

<ProjectReference Include="..\tools\Utilities\RegPreviewUtility\DevHome.RegistryPreview.csproj" />

IfeoTool?


In reply to: 2430464513


Refers to: src/DevHome.csproj:108 in 0c4e347. [](commit_id = 0c4e347, deletion_comment = False)

@jaholme
Copy link
Contributor

jaholme commented Oct 23, 2024

<ProjectReference Include="..\tools\Utilities\RegPreviewUtility\DevHome.RegistryPreview.csproj" />

yes ifeotool


In reply to: 2430489509


Refers to: src/DevHome.csproj:108 in 0c4e347. [](commit_id = 0c4e347, deletion_comment = False)

@jaholme
Copy link
Contributor

jaholme commented Oct 23, 2024

<ProjectReference Include="..\service\DevHome.Service\DevHome.Service.csproj" />

The NT service should go as well, it was only used by devdiagnostics


Refers to: src/DevHome.csproj:87 in 0c4e347. [](commit_id = 0c4e347, deletion_comment = False)

@krschau krschau merged commit c3b1703 into main Oct 28, 2024
4 checks passed
@krschau krschau added this to the Dev Home v0.19 milestone Nov 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants