Update blob file format and enabling dual write #1549
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
pengchen0692
reviewed
May 2, 2022
src/Microsoft.Health.Dicom.Core/Features/Common/DicomFileNameWithPrefix.cs
Outdated
Show resolved
Hide resolved
src/Microsoft.Health.Dicom.Core/Features/Common/HashingHelper.cs
Outdated
Show resolved
Hide resolved
src/Microsoft.Health.Dicom.Core/Features/Common/HashingHelper.cs
Outdated
Show resolved
Hide resolved
src/Microsoft.Health.Dicom.Core/Features/Common/HashingHelper.cs
Outdated
Show resolved
Hide resolved
src/Microsoft.Health.Dicom.Core/Features/Common/HashingHelper.cs
Outdated
Show resolved
Hide resolved
src/Microsoft.Health.Dicom.Core/Features/Common/HashingHelper.cs
Outdated
Show resolved
Hide resolved
src/Microsoft.Health.Dicom.Core/Features/Common/HashingHelper.cs
Outdated
Show resolved
Hide resolved
src/Microsoft.Health.Dicom.Core/Features/Common/HashingHelper.cs
Outdated
Show resolved
Hide resolved
src/Microsoft.Health.Dicom.Blob/Features/Storage/BlobFileStore.cs
Outdated
Show resolved
Hide resolved
src/Microsoft.Health.Dicom.Core/Features/Common/DicomFileNameWithUID.cs
Outdated
Show resolved
Hide resolved
pengchen0692
reviewed
May 2, 2022
src/Microsoft.Health.Dicom.Core/Configs/FeatureConfiguration.cs
Outdated
Show resolved
Hide resolved
pengchen0692
previously approved these changes
May 2, 2022
jovinson-ms
reviewed
May 2, 2022
jovinson-ms
previously approved these changes
May 3, 2022
src/Microsoft.Health.Dicom.Core.UnitTests/Features/Common/DicomFileNameWithPrefixTests.cs
Outdated
Show resolved
Hide resolved
src/Microsoft.Health.Dicom.Core/Features/Common/DicomFileNameWithPrefix.cs
Outdated
Show resolved
Hide resolved
src/Microsoft.Health.Dicom.Blob/Features/Storage/BlobMetadataStore.cs
Outdated
Show resolved
Hide resolved
src/Microsoft.Health.Dicom.Core/Configs/FeatureConfiguration.cs
Outdated
Show resolved
Hide resolved
src/Microsoft.Health.Dicom.Core/Features/Common/HashingHelper.cs
Outdated
Show resolved
Hide resolved
brandonpollett
requested changes
May 3, 2022
src/Microsoft.Health.Dicom.Blob/Features/Storage/BlobFileStore.cs
Outdated
Show resolved
Hide resolved
src/Microsoft.Health.Dicom.Core/Features/Common/DicomFileNameWithPrefix.cs
Outdated
Show resolved
Hide resolved
src/Microsoft.Health.Dicom.Blob/Features/Storage/BlobMetadataStore.cs
Outdated
Show resolved
Hide resolved
We could start with discussions and let them know that dont enable the flag for existing deployments. Is that sounds reasonable to you? |
|
It will be a major version. And Josiah will start a discussions |
jovinson-ms
approved these changes
May 4, 2022
| @@ -74,6 +74,7 @@ | |||
| "DicomFunctions__ConnectionName": "AzureWebJobsStorage", | |||
| "DicomServer__Security__Enabled": "true", | |||
| "DicomServer__Security__Authorization__Enabled": "true", | |||
| "DicomServer__Services__BlobMigration__FormatType": "2", | |||
There was a problem hiding this comment.
Is it possible to have the configuration be the string representation of the enum New? I don't recall for sure off hand, but I believe that would work.
| @@ -202,6 +202,7 @@ | |||
| "DicomFunctions__DurableTask__ConnectionName": "AzureWebJobsStorage", | |||
| "DicomServer__Features__EnableOhifViewer": "[parameters('deployOhifViewer')]", | |||
| "DicomServer__Features__EnableExtendedQueryTags": "true", | |||
| "DicomServer__Services__BlobMigration__FormatType": "2", | |||
There was a problem hiding this comment.
Again, if someone has it setup to pull our CI and use this template to for their deployment, won't this put them in a broken scenario?
| @@ -67,7 +82,7 @@ public class BlobMetadataStore : IMetadataStore | |||
| // Creates a copy of the dataset with bulk data removed. | |||
| DicomDataset dicomDatasetWithoutBulkData = dicomDataset.CopyWithoutBulkDataItems(); | |||
|
|
|||
| BlockBlobClient blob = GetInstanceBlockBlob(dicomDatasetWithoutBulkData.ToVersionedInstanceIdentifier(version)); | |||
| BlockBlobClient[] blobs = GetInstanceBlockBlobClients(dicomDatasetWithoutBulkData.ToVersionedInstanceIdentifier(version)); | |||
There was a problem hiding this comment.
nit: blobs -> blobClients
| }, | ||
| "Services": { | ||
| "BlobMigration": { | ||
| "FormatType": 0 |
There was a problem hiding this comment.
I think we can use a string enum here.
| @@ -75,6 +75,9 @@ | |||
| }, | |||
| "ExtendedQueryTag": { | |||
| "MaxAllowedCount": 128 | |||
| }, | |||
| "BlobMigration": { | |||
| "FormatType": 0 | |||
brandonpollett
approved these changes
May 5, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
As part of blob file name migration, this is the first step to add support dual write if enabled by a flag. It also adds a new flag for new blob format for newly added service.
Added reference to new Hash function
Related issues
Addresses AB#90330.
Testing
New unit tests are added and update the existing config to include the new flag