run connected store tests in separate job with fresh docker-compose #3356
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arunmk-ms
reviewed
Feb 8, 2024
| - script: docker-compose -p healthcare -f docker-compose.yml -f docker-compose.features.yml rm -s -f | ||
| displayName: 'Stop docker-compose' | ||
| workingDirectory: 'docker' | ||
| condition: always() |
There was a problem hiding this comment.
nit: leave extra space at the end
| - script: docker-compose -p healthcare -f docker-compose.yml rm -s -f | ||
| displayName: 'Stop docker-compose' | ||
| workingDirectory: 'docker' | ||
| condition: always() |
There was a problem hiding this comment.
nit: leave extra space at the end
| testResultsFiles: '*.trx' | ||
| searchFolder: '$(Agent.TempDirectory)/TestResults' | ||
| testRunTitle: 'E2E Connected Store Tests' | ||
| buildConfiguration: '$(buildConfiguration)' |
There was a problem hiding this comment.
nit: leave extra space at the end
| testResultsFiles: '*.trx' | ||
| searchFolder: '$(Agent.TempDirectory)/TestResults' | ||
| testRunTitle: 'Partitioned Connected Store E2E Tests' | ||
| buildConfiguration: '$(buildConfiguration)' |
There was a problem hiding this comment.
nit: leave extra space at the end
arunmk-ms
approved these changes
Feb 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Today, we run all e2e tests for both connected store and internal store within same docker-compose run and this sometimes causes space issues. Instead, we will run connected store tests in separate job with fresh docker-compose.
Related issues
Unblocks [AB#105723].