Add configuration to filter health checks #3357
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rnal store health check
bcarthic
reviewed
Feb 9, 2024
| else | ||
| { | ||
| // For local testing with Azurite | ||
| BlobContainerClient blobContainerClient = new BlobContainerClient(_externalStoreOptions.ConnectionString, _externalStoreOptions.ContainerName); |
There was a problem hiding this comment.
Should this be more guarded with env than the uri?
There was a problem hiding this comment.
This is how its done in the ExternalBlobClient
We could guard by the current environment, although technically environment doesn't matter here. If we for some reason wanted to switch to connecting to the blob store via ConnectionString instead of BlobContainerUri, the url generated in the else statement would still be accurate.
bcarthic
reviewed
Feb 10, 2024
src/Microsoft.Health.Dicom.Core/Configs/HealthCheckPublisherConfiguration.cs
Outdated
Show resolved
Hide resolved
bcarthic
approved these changes
Feb 10, 2024
bcarthic
approved these changes
Feb 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add configuration to filter health checks. Any health check can be added to this list, and it will be excluded from running.
Also fixed an issue with running the IDP health check locally - the http pipeline policy required a blob URI to run, which does not exist when running with Azurite
Related issues
Addresses #115147
Testing
Ran locally. Added single & multiple health check names to the list and saw that they were removed from execution. Also tried removing the config all together or using an empty list, in which case all of the health checks will run.