-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Users/mibir/new workflows #4
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The only thing I feel is missing is our ability to push beta packages. I feel now that we have releases, we don't want to release something that we didn't properly test. The release flow needs to enable pushing beta versions (maybe with each commit to main) before we release a stable version
I agree, but I'd rather add that as a feature to this flow rather than complicate the existing setup. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unless there is a compelling argument whey package metadata verification should be part of the Build workflow, we need to move it to the Pack workflow.
@nilay-kapadia can confirm, windows is still needed in the areas where we're running powershell scripts. |
Added/Editedworkflows to support new reusing the new release flow across multiple repos.
Workflows seen working here: https://github.com/microsoft/github-workflows-playground/runs/6582532554?check_suite_focus=true
One thing to note, is that I've included the Verify step as a part of builds now, so that any new repos can use this to make sure their package metadata meets MSFT requirements before finishing the PR.