Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Users/mibir/new workflows #4

Merged
merged 17 commits into from
May 25, 2022
Merged

Users/mibir/new workflows #4

merged 17 commits into from
May 25, 2022

Conversation

ms-mikeb
Copy link
Collaborator

@ms-mikeb ms-mikeb commented May 24, 2022

Added/Editedworkflows to support new reusing the new release flow across multiple repos.

Workflows seen working here: https://github.com/microsoft/github-workflows-playground/runs/6582532554?check_suite_focus=true

One thing to note, is that I've included the Verify step as a part of builds now, so that any new repos can use this to make sure their package metadata meets MSFT requirements before finishing the PR.

@ms-mikeb ms-mikeb self-assigned this May 24, 2022
@ms-mikeb ms-mikeb requested review from a team and amdawood as code owners May 24, 2022 22:20
Copy link
Collaborator

@amdawood amdawood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The only thing I feel is missing is our ability to push beta packages. I feel now that we have releases, we don't want to release something that we didn't properly test. The release flow needs to enable pushing beta versions (maybe with each commit to main) before we release a stable version

.github/workflows/publish.yml Show resolved Hide resolved
.github/workflows/build.yml Show resolved Hide resolved
.github/workflows/build.yml Outdated Show resolved Hide resolved
.github/workflows/sign.yml Outdated Show resolved Hide resolved
.github/workflows/sign.yml Outdated Show resolved Hide resolved
.github/workflows/sign.yml Show resolved Hide resolved
.github/workflows/build.yml Outdated Show resolved Hide resolved
.github/workflows/build.yml Outdated Show resolved Hide resolved
.github/workflows/build.yml Outdated Show resolved Hide resolved
@ms-mikeb
Copy link
Collaborator Author

ms-mikeb commented May 24, 2022

The only thing I feel is missing is our ability to push beta packages. I feel now that we have releases, we don't want to release something that we didn't properly test. The release flow needs to enable pushing beta versions (maybe with each commit to main) before we release a stable version

I agree, but I'd rather add that as a feature to this flow rather than complicate the existing setup.
I've added an issue to track this so it's not forgotten.

@ms-mikeb ms-mikeb requested a review from amdawood May 25, 2022 02:46
Copy link
Collaborator

@amdawood amdawood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unless there is a compelling argument whey package metadata verification should be part of the Build workflow, we need to move it to the Pack workflow.

.github/workflows/build.yml Outdated Show resolved Hide resolved
@ms-mikeb ms-mikeb requested a review from amdawood May 25, 2022 18:01
Isai-Cicourel
Isai-Cicourel previously approved these changes May 25, 2022
nilay-kapadia
nilay-kapadia previously approved these changes May 25, 2022
amdawood
amdawood previously approved these changes May 25, 2022
@ms-mikeb ms-mikeb dismissed stale reviews from amdawood and nilay-kapadia via 7a46356 May 25, 2022 18:26
nilay-kapadia
nilay-kapadia previously approved these changes May 25, 2022
@ms-mikeb
Copy link
Collaborator Author

@nilay-kapadia can confirm, windows is still needed in the areas where we're running powershell scripts.

@amdawood amdawood self-requested a review May 25, 2022 18:38
@ms-mikeb ms-mikeb merged commit 5db9471 into main May 25, 2022
@ms-mikeb ms-mikeb deleted the users/mibir/new-workflows branch June 21, 2022 19:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants