Skip to content
This repository has been archived by the owner on Jul 15, 2023. It is now read-only.

The HyperLinks to About and Privacy docs on Portability Analyzer Setting are not navigatable #765

Merged
merged 1 commit into from
Jun 12, 2019
Merged

The HyperLinks to About and Privacy docs on Portability Analyzer Setting are not navigatable #765

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/ApiPort/ApiPort.VisualStudio/Views/OptionsPageControl.xaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -186,7 +186,7 @@

<TextBlock Grid.Column="2"
HorizontalAlignment="Right">
<Hyperlink RequestNavigate="NavigateToMoreInformation"
<Hyperlink NavigateUri="DocumentationLinks.About" RequestNavigate="NavigateToMoreInformation"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this needed? Looks like you either need to set the uri or could consolidate the event handlers

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, adding the uri actually fixed the original problem. Looks like consolidate the event handler only is not enough.

AutomationProperties.Name="{x:Static const:LocalizedStrings.AboutTool}">
<TextBlock Text="{x:Static const:LocalizedStrings.AboutTool}"
KeyboardNavigation.IsTabStop="True"
Expand All @@ -196,7 +196,7 @@

<TextBlock Grid.Column="4"
HorizontalAlignment="Right">
<Hyperlink RequestNavigate="NavigateToPrivacyModel"
<Hyperlink NavigateUri="DocumentationLinks.PrivacyPolicy" RequestNavigate="NavigateToPrivacyModel"
AutomationProperties.Name="{x:Static const:LocalizedStrings.AboutPrivacy}">
<TextBlock Text="{x:Static const:LocalizedStrings.AboutPrivacy}"
KeyboardNavigation.IsTabStop="True"
Expand Down
2 changes: 1 addition & 1 deletion src/ApiPort/ApiPort.VisualStudio/Views/OptionsPageControl.xaml.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ public OptionsPageControl(OptionsViewModel viewModel, IVsStatusbar statusBar)
Unloaded += (s, e) => viewModel.Save();
}

private void NavigateToPrivacyModel(object sender, RequestNavigateEventArgs e) => Process.Start(DocumentationLinks.About.OriginalString);
private void NavigateToPrivacyModel(object sender, RequestNavigateEventArgs e) => Process.Start(DocumentationLinks.PrivacyPolicy.OriginalString);

private void NavigateToMoreInformation(object sender, RequestNavigateEventArgs e) => Process.Start(DocumentationLinks.About.OriginalString);

Expand Down