Skip to content
This repository has been archived by the owner on Jul 15, 2023. It is now read-only.

DGML fails when there is unresolved dependency #796

Merged
merged 1 commit into from
Aug 23, 2019
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,7 @@ public Task WriteStreamAsync(Stream stream, AnalyzeResponse response)
dgml.AddNode(nodeGuid, nodeTitle,
nodeCategory,
portabilityIndex,
group: missingTypes.Length == 0 ? null : "Collapsed");
group: string.IsNullOrEmpty(missingTypes) ? null : "Collapsed");

if (dgml.TryGetId(tfm, out Guid frameworkGuid))
{
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -105,6 +105,12 @@ public bool TryGetAPICountFromReferences(int target, out int availAPIs, out int

foreach (var item in Nodes)
{
if (item.UsageData == null)
{
// skip the Node with no UsageData
continue;
Lxiamail marked this conversation as resolved.
Show resolved Hide resolved
}

if (!item.TryGetAPICountFromReferences(target, out int refCountAvail, out int refCountUnavail))
{
// Cycle!
Expand Down