Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use upstream react/iframe-missing-sandbox #63

Merged
merged 1 commit into from
Oct 3, 2024

Conversation

mkacmar
Copy link
Collaborator

@mkacmar mkacmar commented Oct 1, 2024

This PR replaces our custom rule with an upstream version (ref #30) - I ran our tests against the upstream rule an all passes.

@mkacmar mkacmar requested a review from a team October 1, 2024 10:12
@mkacmar mkacmar force-pushed the dev/mkacmar/react-iframe-missing-sandbox branch from 05e6523 to 1cf24f6 Compare October 1, 2024 20:07
@mkacmar mkacmar force-pushed the dev/mkacmar/react-iframe-missing-sandbox branch from 1cf24f6 to b6085d0 Compare October 3, 2024 08:04
Copy link

@lukaskohl-msft lukaskohl-msft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@mkacmar mkacmar merged commit d448aac into main Oct 3, 2024
10 checks passed
@mkacmar mkacmar deleted the dev/mkacmar/react-iframe-missing-sandbox branch October 3, 2024 08:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants