Adaptive UI Explorer - initial port #6424
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bheston
requested review from
chrisdholt,
Falkicon,
EisenbergEffect,
janechu and
nicholasrice
as code owners
nicholasrice
reviewed
Oct 3, 2022
nicholasrice
reviewed
Oct 3, 2022
| LayerBackground; | ||
| SampleApp; | ||
|
|
||
| const sampleTemplate = html<App>` |
There was a problem hiding this comment.
Is this template needed?
There was a problem hiding this comment.
It's coming back. Right now the sample page uses Fluent UI, but I want to make that all configurable so it works with anyone's Foundation-base components.
nicholasrice
reviewed
Oct 3, 2022
|
|
||
| componentTypeTemplate(): ViewTemplate<App, any> { | ||
| // if (this.componentType === ComponentType.sample) { | ||
| // return sampleTemplate; |
There was a problem hiding this comment.
Are these comments needed?
There was a problem hiding this comment.
Goes with the above template.
nicholasrice
reviewed
Oct 3, 2022
nicholasrice
reviewed
Oct 3, 2022
| backplate = "backplate", | ||
| text = "text", | ||
| form = "form", | ||
| // sample = "sample", |
There was a problem hiding this comment.
Goes with previous comments.
nicholasrice
reviewed
Oct 3, 2022
packages/tooling/adaptive-ui-explorer/src/components/adaptive-component.ts
Outdated
Show resolved
Hide resolved
EisenbergEffect
approved these changes
Oct 14, 2022
bheston
force-pushed
the
users/bheston/adaptive-ui-explorer
branch
from
d5cb5f4 to
7ac029f
Compare
nicholasrice
approved these changes
Oct 18, 2022
chrisdholt
approved these changes
Oct 18, 2022
janechu
pushed a commit
that referenced
this pull request
Jun 10, 2024
Initial port of Color Explorer into the new Adaptive UI Explorer component
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
📖 Description
A new package for the Adaptive UI Explorer. Initially this is a port of the Color Explorer and updated for the latest FAST Element.
The intent is both that this is a place to rapidly iterate on Adaptive UI capabilities as well as a set of components that consumers can use to showcase their own Adaptive UI tokens or values.
It will be updated to support setting all design token values as well as previewing individual combinations, centering more around the effects of the systems than individual components.
👩💻 Reviewer Notes
This is mostly a port from the Color Explorer site, which had some minor cleanup under Fluent UI, and again some updates for the latest FAST Foundation.
✅ Checklist
General
$ yarn change⏭ Next Steps
Update the Color Explorer site to use this component and republish that site.