This repository has been archived by the owner on Mar 4, 2020. It is now read-only.
fix: use and mock lodash debounce in Carousel and Dropdown #2203
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
silviuaavram
requested review from
dvdzkwsk,
dzearing,
ecraig12345,
JasonGore,
jdhuntington,
kenotron,
layershifter,
levithomason,
miroslavstastny and
mnajdova
as code owners
silviuaavram
changed the title
layershifter
reviewed
Jan 3, 2020
| componentWillUnmount() { | ||
| clearTimeout(this.a11yStatusTimeout) | ||
| clearTimeout(this.charKeysPressedTimeout) | ||
| } |
There was a problem hiding this comment.
Please add an cancel() call for _.debounce:
There was a problem hiding this comment.
you mean this.clearStartingString.cancel() ?
There was a problem hiding this comment.
I believe this.focusItemAtIndex.cancel() as well
There was a problem hiding this comment.
Solved. Thanks!
Perf comparison
Generated by 🚫 dangerJS |
dzearing
reviewed
Jan 7, 2020
| @@ -213,8 +212,7 @@ class Carousel extends AutoControlledComponent<WithAsProp<CarouselProps>, Carous | |||
| itemRefs = [] as React.RefObject<HTMLElement>[] | |||
| paddleNextRef = React.createRef<HTMLElement>() | |||
| paddlePreviousRef = React.createRef<HTMLElement>() | |||
|
|
|||
| focusItemAtIndex = debounce((index: number) => { | |||
| focusItemAtIndex = _.debounce((index: number) => { | |||
There was a problem hiding this comment.
Minor nullref edge case if you don't cancel this.
silviuaavram
force-pushed
the
chore/debounce-mock-refactor
branch
from
fd6f063
to
c803d83
Compare
layershifter
approved these changes
Jan 7, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed in-house implementation of
debounceand replaced its uses with_.debounceinDropdownandCarousel.Properly mocked the function in
Dropdown-testas it wasn't working with jest timers. Details in jestjs/jest#3465 and other similar Github issues.