This repository has been archived by the owner on Mar 4, 2020. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 54
chore(Image): replace withSafeTypeForAs
#2372
Open
layershifter
wants to merge
6
commits into
master
Choose a base branch
from
chore/try-strict-types
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
layershifter
requested review from
dvdzkwsk,
dzearing,
ecraig12345,
JasonGore,
jdhuntington,
kenotron,
levithomason,
miroslavstastny and
mnajdova
as code owners
February 19, 2020 14:02
layershifter
changed the title
proto: use type safe "as"
chore(Image): replace Feb 19, 2020
withSafeTypeForAs
Perf comparison
Perf tests with no regressions
Generated by 🚫 dangerJS |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WAT? ☃️
Currently we have
withSafeTypeForAs
utility which partially solves polymorphic typings foras
prop but it's too complex and creates over-complicated type definitions indist
.This PR removes usage of
withSafeTypeForAs
inImage
with simple typings. Approach is inspired by recent changes inemotion
: emotion-js/emotion#1405 & react-polymorphic-box. It's also compatibleReact.forwardRef
.Test snippet 🛠
Fixes #1527