Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replacing deprecated StatelessComponent references with FunctionComponent #11891

Merged
merged 4 commits into from
Feb 11, 2020
Merged

Replacing deprecated StatelessComponent references with FunctionComponent #11891

merged 4 commits into from
Feb 11, 2020

Conversation

khmakoto
Copy link
Member

@khmakoto khmakoto commented Feb 6, 2020 •
edited
Loading

Pull request checklist

Description of changes

This PR changes all mentions of the deprecated React.StatelessComponent to React.FunctionComponent across the repo.

Focus areas to test

(optional)

Microsoft Reviewers: Open in CodeFlow

@khmakoto khmakoto changed the title Function component Replacing deprecated StatelessComponent references with FunctionComponent Feb 6, 2020
@JasonGore
Copy link
Member

Ken and I are in the middle of merging the repos so we may want to put a hold on these types of PRs. @kenotron What do you think?

@kenotron
Copy link
Member

kenotron commented Feb 6, 2020

Ken and I are in the middle of merging the repos so we may want to put a hold on these types of PRs. @kenotron What do you think?

We best wait here - I know it's probably all gonna be okay but I bet you a cookie it'll mess with some weird typings at least.

@msft-github-bot
Copy link
Contributor

msft-github-bot commented Feb 6, 2020 •
edited
Loading

Component Perf Analysis

No significant results to display.

All results

Scenario Master Ticks PR Ticks Status
BaseButton 682 705
BaseButton (experiments) 879 884
DefaultButton 986 961
DefaultButton (experiments) 1801 1836
DetailsRow 3257 3157
DetailsRow (fast icons) 3373 3308
DetailsRow without styles 2992 3081
DocumentCardTitle with truncation 1594 1612
MenuButton 1321 1293
MenuButton (experiments) 3375 3413
PrimaryButton 1163 1147
PrimaryButton (experiments) 1877 1894
SplitButton 2790 2733
SplitButton (experiments) 6881 6952
Stack 439 449
Stack with Intrinsic children 1083 1071
Stack with Text children 3952 3896
Text 356 346
Toggle 814 797
Toggle (experiments) 2216 2164
button 53 74

@khmakoto
Copy link
Member Author

khmakoto commented Feb 6, 2020

@kenotron and @JasonGore I'll leave the PR open but add a Do not merge tag until the repo merging is done, what do you think about that?

@size-auditor
Copy link

size-auditor bot commented Feb 6, 2020 •
edited
Loading

Asset size changes

Size Auditor did not detect a change in bundle size for any component!

Baseline commit: 00b6694e2bd2f1de1713f9303fdff5dd63fcda9e (build)

ecraig12345
ecraig12345 approved these changes Feb 6, 2020
View reviewed changes
Copy link
Member

@ecraig12345 ecraig12345 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@JasonGore JasonGore merged commit 0afa4fa into microsoft:master Feb 11, 2020
@khmakoto khmakoto deleted the functionComponent branch February 11, 2020 23:12
@msft-github-bot
Copy link
Contributor

🎉@uifabric/utilities@v7.12.0 has been released which incorporates this pull request.:tada:

Handy links:

@msft-github-bot
Copy link
Contributor

🎉@uifabric/fabric-website@v7.9.0 has been released which incorporates this pull request.:tada:

Handy links:

@msft-github-bot
Copy link
Contributor

🎉@uifabric/fabric-website-resources@v7.6.0 has been released which incorporates this pull request.:tada:

Handy links:

@msft-github-bot
Copy link
Contributor

🎉@uifabric/experiments@v7.19.0 has been released which incorporates this pull request.:tada:

Handy links:

@msft-github-bot
Copy link
Contributor

🎉@uifabric/example-app-base@v7.12.0 has been released which incorporates this pull request.:tada:

Handy links:

@msft-github-bot
Copy link
Contributor

🎉office-ui-fabric-react@v7.93.0 has been released which incorporates this pull request.:tada:

Handy links:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ecraig12345 ecraig12345 ecraig12345 approved these changes

@joschect joschect joschect approved these changes

@kenotron kenotron Awaiting requested review from kenotron

@dzearing dzearing Awaiting requested review from dzearing

@xugao xugao Awaiting requested review from xugao

@aditima aditima Awaiting requested review from aditima

@aneeshack4 aneeshack4 Awaiting requested review from aneeshack4

@atneik atneik Awaiting requested review from atneik

@cliffkoh cliffkoh Awaiting requested review from cliffkoh

@Jahnp Jahnp Awaiting requested review from Jahnp

@JasonGore JasonGore Awaiting requested review from JasonGore

@jdhuntington jdhuntington Awaiting requested review from jdhuntington

@KevinTCoughlin KevinTCoughlin Awaiting requested review from KevinTCoughlin

@leddie24 leddie24 Awaiting requested review from leddie24

@Markionium Markionium Awaiting requested review from Markionium

@micahgodbolt micahgodbolt Awaiting requested review from micahgodbolt

@mtennoe mtennoe Awaiting requested review from mtennoe

@natalieethell natalieethell Awaiting requested review from natalieethell

@ThomasMichon ThomasMichon Awaiting requested review from ThomasMichon

@Vitalius1 Vitalius1 Awaiting requested review from Vitalius1

@yiminwu yiminwu Awaiting requested review from yiminwu

Assignees

@xugao xugao

Labels
PR: API Modified
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@khmakoto @JasonGore @kenotron @msft-github-bot @ecraig12345 @joschect @xugao