Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: remove circular dependency in shadow DOM code path #32492

Closed
wants to merge 2 commits into from
Closed

fix: remove circular dependency in shadow DOM code path #32492

wants to merge 2 commits into from

Conversation

spmonahan
Copy link
Contributor

Previous Behavior

Apps using AMD might run into issues with circular dependencies.

New Behavior

Circular deps are removed.

@fabricteam
Copy link
Collaborator

fabricteam commented Sep 9, 2024 •
edited
Loading

📊 Bundle size report

Package & Exports Baseline (minified/GZIP) PR Change
react
ActivityItem		 71.224 kB
23.353 kB		 71.236 kB
23.357 kB		 12 B
4 B
react
Announced		 38.48 kB
13.282 kB		 38.493 kB
13.297 kB		 13 B
15 B
react
Breadcrumb		 202.185 kB
60.419 kB		 202.2 kB
60.421 kB		 15 B
2 B
react
Button		 195.64 kB
56.642 kB		 195.652 kB
56.648 kB		 12 B
6 B
react
ButtonGrid		 180.571 kB
54.626 kB		 180.586 kB
54.634 kB		 15 B
8 B
react
Calendar		 121.763 kB
37.01 kB		 121.776 kB
37.029 kB		 13 B
19 B
react
Callout		 84.292 kB
27.63 kB		 84.33 kB
27.648 kB		 38 B
18 B
react
Check		 53.185 kB
17.843 kB		 53.204 kB
17.848 kB		 19 B
5 B
react
Checkbox		 59.971 kB
19.889 kB		 59.985 kB
19.903 kB		 14 B
14 B
react
ChoiceGroup		 65.48 kB
21.488 kB		 65.494 kB
21.489 kB		 14 B
1 B
react
ChoiceGroupOption		 58.748 kB
19.364 kB		 58.767 kB
19.362 kB		 19 B
-2 B
react
Coachmark		 93.132 kB
29.416 kB		 93.151 kB
29.428 kB		 19 B
12 B
react
ColorPicker		 135.222 kB
42.228 kB		 135.241 kB
42.223 kB		 19 B
-5 B
react
ComboBox		 252.077 kB
72.336 kB		 252.089 kB
72.324 kB		 12 B
-12 B
react
CommandBar		 203.226 kB
60.147 kB		 203.241 kB
60.163 kB		 15 B
16 B
react
ContextualMenu		 155.108 kB
48.186 kB		 155.133 kB
48.198 kB		 25 B
12 B
react
DatePicker		 184.185 kB
56.175 kB		 184.204 kB
56.175 kB		 19 B
react
DetailsList		 229.966 kB
65.926 kB		 229.978 kB
65.921 kB		 12 B
-5 B
react
Dialog		 211.492 kB
63.169 kB		 211.507 kB
63.176 kB		 15 B
7 B
react
Divider		 19.591 kB
6.841 kB		 19.603 kB
6.845 kB		 12 B
4 B
react
DocumentCard		 217.178 kB
64.45 kB		 217.193 kB
64.46 kB		 15 B
10 B
react
Dropdown		 234.124 kB
68.674 kB		 234.139 kB
68.671 kB		 15 B
-3 B
react
Fabric		 41.732 kB
14.349 kB		 41.745 kB
14.366 kB		 13 B
17 B
react
Facepile		 210.78 kB
63.193 kB		 210.792 kB
63.207 kB		 12 B
14 B
react
FloatingPicker		 242.221 kB
69.023 kB		 242.234 kB
69.035 kB		 13 B
12 B
react
Grid		 180.571 kB
54.626 kB		 180.586 kB
54.634 kB		 15 B
8 B
react
GroupedList		 135.03 kB
40.749 kB		 135.049 kB
40.758 kB		 19 B
9 B
react
GroupedListV2		 122.619 kB
37.852 kB		 122.638 kB
37.857 kB		 19 B
5 B
react
HoverCard		 97.16 kB
30.816 kB		 97.179 kB
30.82 kB		 19 B
4 B
react
Icon		 51.873 kB
17.266 kB		 51.885 kB
17.272 kB		 12 B
6 B
react
Image		 46.887 kB
15.703 kB		 46.904 kB
15.707 kB		 17 B
4 B
react
Keytip		 81.661 kB
26.758 kB		 81.693 kB
26.766 kB		 32 B
8 B
react
KeytipLayer		 103.459 kB
32.014 kB		 103.478 kB
32.017 kB		 19 B
3 B
react
Keytips		 106.227 kB
33.014 kB		 106.239 kB
33.023 kB		 12 B
9 B
react
Label		 38.335 kB
13.251 kB		 38.347 kB
13.257 kB		 12 B
6 B
react
Layer		 48.084 kB
16.358 kB		 48.099 kB
16.367 kB		 15 B
9 B
react
Link		 39.668 kB
13.662 kB		 39.682 kB
13.67 kB		 14 B
8 B
react
MarqueeSelection		 74.528 kB
22.424 kB		 74.541 kB
22.44 kB		 13 B
16 B
react
MessageBar		 190.675 kB
57.075 kB		 190.69 kB
57.08 kB		 15 B
5 B
react
Modal		 93.657 kB
30.253 kB		 93.676 kB
30.267 kB		 19 B
14 B
react
Nav		 188.175 kB
56.524 kB		 188.192 kB
56.532 kB		 17 B
8 B
react
OverflowSet		 33.376 kB
11.317 kB		 33.393 kB
11.329 kB		 17 B
12 B
react
Overlay		 40.889 kB
14.084 kB		 40.902 kB
14.095 kB		 13 B
11 B
react
Panel		 201.233 kB
60.035 kB		 201.25 kB
60.029 kB		 17 B
-6 B
react
Persona		 114.83 kB
36.503 kB		 114.849 kB
36.512 kB		 19 B
9 B
react
PersonaCoin		 114.83 kB
36.503 kB		 114.849 kB
36.512 kB		 19 B
9 B
react
PersonaPresence		 58.055 kB
19.378 kB		 58.074 kB
19.384 kB		 19 B
6 B
react
Pickers		 294.244 kB
82.438 kB		 294.256 kB
82.448 kB		 12 B
10 B
react
Pivot		 189.068 kB
57.252 kB		 189.084 kB
57.265 kB		 16 B
13 B
react
PositioningContainer		 73.838 kB
23.759 kB		 73.85 kB
23.765 kB		 12 B
6 B
react
ProgressIndicator		 39.491 kB
13.54 kB		 39.504 kB
13.554 kB		 13 B
14 B
react
Rating		 81.995 kB
26.107 kB		 82.014 kB
26.112 kB		 19 B
5 B
react
Fluent UI React (entire library)		 1.014 MB
281.935 kB		 1.014 MB
282.093 kB		 106 B
158 B
react
ScrollablePane		 55.551 kB
17.729 kB		 55.563 kB
17.734 kB		 12 B
5 B
react
SearchBox		 188.95 kB
56.685 kB		 188.965 kB
56.684 kB		 15 B
-1 B
react
SelectedItemsList		 232.732 kB
67.931 kB		 232.744 kB
67.931 kB		 12 B
react
Separator		 35.372 kB
12.142 kB		 35.384 kB
12.146 kB		 12 B
4 B
react
Shimmer		 49.238 kB
16.264 kB		 49.259 kB
16.268 kB		 21 B
4 B
react
ShimmeredDetailsList		 240.748 kB
68.656 kB		 240.76 kB
68.667 kB		 12 B
11 B
react
Slider		 57.639 kB
19.206 kB		 57.651 kB
19.217 kB		 12 B
11 B
react
SpinButton		 192.651 kB
57.78 kB		 192.668 kB
57.788 kB		 17 B
8 B
react
Spinner		 41.764 kB
14.469 kB		 41.777 kB
14.478 kB		 13 B
9 B
react
SwatchColorPicker		 190.896 kB
58.128 kB		 190.911 kB
58.135 kB		 15 B
7 B
react
TeachingBubble		 205.952 kB
61.057 kB		 205.967 kB
61.052 kB		 15 B
-5 B
react
TextField		 80.792 kB
25.333 kB		 80.816 kB
25.332 kB		 24 B
-1 B
react
TimePicker		 241.859 kB
70.092 kB		 241.871 kB
70.07 kB		 12 B
-22 B
react
Toggle		 46.21 kB
15.966 kB		 46.225 kB
15.986 kB		 15 B
20 B
react
Tooltip		 87.324 kB
28.217 kB		 87.338 kB
28.223 kB		 14 B
6 B
react
Utilities		 82.675 kB
25.119 kB		 82.779 kB
25.103 kB		 104 B
-16 B
react
WeeklyDayPicker		 101.917 kB
31.829 kB		 101.929 kB
31.829 kB		 12 B
Unchanged fixtures
Package & Exports Size (minified/GZIP)
react
Autofill		 15.428 kB
4.768 kB
react
Color		 7.789 kB
3.127 kB
react
DateTimeUtilities		 5.244 kB
1.849 kB
react
DragDrop		 8.343 kB
2.724 kB
react
DraggableZone		 34.305 kB
11.509 kB
react
ExtendedPicker		 96.795 kB
27.893 kB
react
FocusTrapZone		 17.03 kB
5.924 kB
react
FocusZone		 55.053 kB
17.47 kB
react
Icons		 66.361 kB
24.397 kB
react
KeytipData		 14.028 kB
4.587 kB
react
List		 39.4 kB
12.481 kB
react
Popup		 12.294 kB
4.195 kB
react
Positioning		 22.807 kB
7.701 kB
react
ResizeGroup		 13.338 kB
4.377 kB
react
ResponsiveMode		 8.13 kB
2.966 kB
react
SelectableOption		 724 B
413 B
react
Selection		 42.464 kB
12.301 kB
react
Stack		 41.734 kB
14.268 kB
react
Sticky		 32.613 kB
10.509 kB
react
Styling		 46.033 kB
15.135 kB
react
Text		 36.908 kB
12.822 kB
react
Theme		 43.501 kB
14.183 kB
react
ThemeGenerator		 12.392 kB
4.126 kB
react
Viewport		 23.888 kB
7.656 kB
react
WindowProvider		 1.059 kB
541 B
🤖 This report was generated against 3a68e589a477f4ae97e825913d8721ed44ecbb7e

fabricteam
fabricteam reviewed Sep 9, 2024
View reviewed changes
packages/utilities/etc/utilities.api.md
@@ -1363,7 +1363,7 @@ export const useMergeStylesHooks: () => {
useMergeStylesShadowRootContext: MergeStylesShadowRootContetHook;
Copy link
Collaborator

@fabricteam fabricteam Sep 9, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🕵🏾‍♀️ visual regressions to review in the fluentuiv8 Visual Regression Report

Callout 22 screenshots
Image Name Diff(in Pixels) Image Type
Callout.Beak 25.chromium.png 2715 Changed
Callout.Rendering callout attached to a rectangle.chromium.png 2715 Changed
Callout.Bottom left edge.chromium.png 2715 Changed
Callout.Bottom Right Edge RTL.chromium.png 3749 Changed
Callout.Bottom auto edge.chromium.png 2715 Changed
Callout.Left center.chromium.png 2715 Changed
Callout.Left bottom edge.chromium.png 2715 Changed
Callout.Gap space 25.chromium.png 2715 Changed
Callout.Left top edge.chromium.png 2715 Changed
Callout.No beak.chromium.png 2715 Changed
Callout.Bottom Left Edge RTL.chromium.png 3749 Changed
Callout.Bottom center.chromium.png 2715 Changed
Callout.Right bottom edge.chromium.png 2715 Changed
Callout.No callout width specified.chromium.png 2715 Changed
Callout.Bottom right edge.chromium.png 2715 Changed
Callout.Right center.chromium.png 2715 Changed
Callout.Root.chromium.png 2715 Changed
Callout.Right top edge.chromium.png 2715 Changed
Callout.Top right edge.chromium.png 2715 Changed
Callout.Top center.chromium.png 2715 Changed
Callout.Top auto edge.chromium.png 2715 Changed
Callout.Top left edge.chromium.png 2715 Changed
Checkbox 13 screenshots
Image Name Diff(in Pixels) Image Type
Checkbox.Controlled Indeterminate disabled.chromium.png 2471 Changed
Checkbox.Checked.chromium.png 2471 Changed
Checkbox.Checked disabled.chromium.png 2471 Changed
Checkbox.Controlled Indeterminate.chromium.png 2471 Changed
Checkbox.End RTL.chromium.png 3175 Changed
Checkbox.Custom render Checkbox.chromium.png 2471 Changed
Checkbox.Unchecked RTL.chromium.png 3175 Changed
Checkbox.Multi-line Checkbox.chromium.png 2471 Changed
Checkbox.End.chromium.png 2471 Changed
Checkbox.Unchecked disabled.chromium.png 2471 Changed
Checkbox.Unchecked.chromium.png 2471 Changed
Checkbox.Uncontrolled Indeterminate.chromium.png 2471 Changed
Checkbox.Uncontrolled Indeterminate disabled.chromium.png 2471 Changed
Checkbox Indeterminate 4 screenshots
Image Name Diff(in Pixels) Image Type
Checkbox Indeterminate.Uncontrolled and Controlled Indeterminate checkbox.chromium.png 2294 Changed
Checkbox Indeterminate.Controlled Indeterminate checkbox without onChange callback.chromium.png 2294 Changed
Checkbox Indeterminate.Uncontrolled Indeterminate defaultChecked checkbox.chromium.png 2294 Changed
Checkbox Indeterminate.Uncontrolled Indeterminate checkbox.chromium.png 2294 Changed
ChoiceGroup 6 screenshots
Image Name Diff(in Pixels) Image Type
ChoiceGroup.Root.chromium.png 3036 Changed
ChoiceGroup.With default size images.chromium.png 3036 Changed
ChoiceGroup.Required.chromium.png 3036 Changed
ChoiceGroup.With Icons RTL.chromium.png 4069 Changed
ChoiceGroup.With large size images.chromium.png 3036 Changed
ChoiceGroup.With icons.chromium.png 3036 Changed
ColorPicker 3 screenshots
Image Name Diff(in Pixels) Image Type
ColorPicker.Blue.chromium.png 3297 Changed
ColorPicker.Root.chromium.png 3297 Changed
ColorPicker.Root RTL.chromium.png 4332 Changed
DocumentCard 4 screenshots
Image Name Diff(in Pixels) Image Type
DocumentCard.Compact with preview image.chromium.png 3021 Changed
DocumentCard.Compact with preview list.chromium.png 3021 Changed
DocumentCard.Not truncated.chromium.png 3021 Changed
DocumentCard.With secondary title style.chromium.png 3021 Changed
FolderCover 5 screenshots
Image Name Diff(in Pixels) Image Type
FolderCover.Large Default Cover.chromium.png 2993 Changed
FolderCover.Large Media Cover.chromium.png 2993 Changed
FolderCover.Shared Cover.chromium.png 2993 Changed
FolderCover.Small Media Cover.chromium.png 2993 Changed
FolderCover.Small Default Cover.chromium.png 2993 Changed
HoverCard 2 screenshots
Image Name Diff(in Pixels) Image Type
HoverCard.Root.chromium.png 2715 Changed
HoverCard.Root RTL.chromium.png 3749 Changed
Icon 3 screenshots
Image Name Diff(in Pixels) Image Type
Icon.Color.chromium.png 2984 Changed
Icon.Image.chromium.png 2984 Changed
Icon.Root.chromium.png 2984 Changed
Image 21 screenshots
Image Name Diff(in Pixels) Image Type
Image.Fit- CenterContain, image larger.chromium.png 3183 Changed
Image.Fit- CenterContain, image smaller.chromium.png 3183 Changed
Image.Fit- CenterContain, image wider.chromium.png 3183 Changed
Image.Fit- CenterContain, image taller.chromium.png 3183 Changed
Image.Fit- centerCover, image larger.chromium.png 3183 Changed
Image.Fit- center, image larger.chromium.png 3183 Changed
Image.Fit- centerCover, image wider.chromium.png 3183 Changed
Image.Fit- contain, image taller.chromium.png 3183 Changed
Image.Fit- contain, image wider.chromium.png 3183 Changed
Image.Fit- center, image smaller.chromium.png 3183 Changed
Image.Fit- centerCover, image smaller.chromium.png 3183 Changed
Image.Fit- centerCover, image taller.chromium.png 3183 Changed
Image.Fit- none, image smaller.chromium.png 3183 Changed
Image.Fit- cover, image wider.chromium.png 3183 Changed
Image.Maximize frame, landscape container.chromium.png 3183 Changed
Image.Fit- cover, image taller.chromium.png 3183 Changed
Image.Fit- none, image larger.chromium.png 3183 Changed
Image.Maximize frame, portrait container.chromium.png 4680 Changed
Image.No fit, no w-h.chromium.png 3183 Changed
Image.No fit, only height.chromium.png 3183 Changed
Image.No fit, only width.chromium.png 3183 Changed
Keytip 3 screenshots
Image Name Diff(in Pixels) Image Type
Keytip.Offset.chromium.png 2715 Changed
Keytip.Root.chromium.png 2715 Changed
Keytip.Disabled.chromium.png 2715 Changed
Label 4 screenshots
Image Name Diff(in Pixels) Image Type
Label.Disabled.chromium.png 829 Changed
Label.Root RTL.chromium.png 827 Changed
Label.Root.chromium.png 829 Changed
Label.Required.chromium.png 829 Changed
Layer 2 screenshots
Image Name Diff(in Pixels) Image Type
Layer.Root.chromium.png 2956 Changed
Layer.Root RTL.chromium.png 4743 Changed
Link 7 screenshots
Image Name Diff(in Pixels) Image Type
Link.No Href.chromium.png 721 Changed
Link.Disabled.chromium.png 721 Changed
Link.Root RTL.chromium.png 718 Changed
Link.No Href Disabled.chromium.png 721 Changed
Link.Root.chromium.png 721 Changed
Link.Underlined Disabled.chromium.png 721 Changed
Link.Underlined.chromium.png 721 Changed
MediaTile 4 screenshots
Image Name Diff(in Pixels) Image Type
MediaTile.Media tile with nameplate hidden until hover.chromium.png 2993 Changed
MediaTile.Media tile with single activity line.chromium.png 2993 Changed
MediaTile.Media tile with very long name and activity.chromium.png 2993 Changed
MediaTile.Media tile with two activity lines.chromium.png 2993 Changed
Modal 2 screenshots
Image Name Diff(in Pixels) Image Type
Modal.Root.chromium.png 2013 Changed
Modal.Modeless.chromium.png 2013 Changed
Overlay 3 screenshots
Image Name Diff(in Pixels) Image Type
Overlay.Root RTL.chromium.png 699 Changed
Overlay.Dark.chromium.png 695 Changed
Overlay.Root.chromium.png 695 Changed
Persona 16 screenshots
Image Name Diff(in Pixels) Image Type
Persona.Initials RTL.chromium.png 2716 Changed
Persona.Initials.chromium.png 2013 Changed
Persona.Size 100 Extra Large RTL.chromium.png 2716 Changed
Persona.Persona with children.chromium.png 2013 Changed
Persona.Size 120 RTL.chromium.png 2716 Changed
Persona.default size, details hidden.chromium.png 2013 Changed
Persona.size10 (tiny).chromium.png 2013 Changed
Persona.size100 (extraLarge).chromium.png 2013 Changed
Persona.size28 (extraSmall).chromium.png 2013 Changed
Persona.default size, presences.chromium.png 2013 Changed
Persona.size120.chromium.png 2013 Changed
Persona.size24 (extraExtraSmall).chromium.png 2013 Changed
Persona.size40 (small).chromium.png 2013 Changed
Persona.size48 (regular).chromium.png 2013 Changed
Persona.size32.chromium.png 2013 Changed
Persona.size72 (large).chromium.png 2013 Changed
ProgressIndicator 4 screenshots
Image Name Diff(in Pixels) Image Type
ProgressIndicator.50 RTL.chromium.png 709 Changed
ProgressIndicator.50%.chromium.png 702 Changed
ProgressIndicator.0%.chromium.png 702 Changed
ProgressIndicator.100%.chromium.png 702 Changed
ScrollablePane 1 screenshots
Image Name Diff(in Pixels) Image Type
ScrollablePane.Default ScrollablePane Example.chromium.png 1026 Changed
Separator 12 screenshots
Image Name Diff(in Pixels) Image Type
Separator.Horizontal Start Aligned RTL.chromium.png 737 Changed
Separator.Horizontal End Aligned.chromium.png 736 Changed
Separator.Root RTL.chromium.png 737 Changed
Separator.Horizontal End Aligned RTL.chromium.png 737 Changed
Separator.Horizontal Start Aligned.chromium.png 736 Changed
Separator.Root.chromium.png 736 Changed
Separator.Vertical End Aligned RTL.chromium.png 737 Changed
Separator.Vertical Center Aligned.chromium.png 736 Changed
Separator.Vertical Center Aligned RTL.chromium.png 737 Changed
Separator.Vertical End Aligned.chromium.png 736 Changed
Separator.Vertical Start Aligned RTL.chromium.png 737 Changed
Separator.Vertical Start Aligned.chromium.png 736 Changed
Shimmer 8 screenshots
Image Name Diff(in Pixels) Image Type
Shimmer.50% width.chromium.png 685 Changed
Shimmer.Circle Gap Line.chromium.png 685 Changed
Shimmer.Circle Gap Line RTL.chromium.png 687 Changed
Shimmer.Basic.chromium.png 685 Changed
Shimmer.Custom elements on themed background.chromium.png 685 Changed
Shimmer.Data not loaded.chromium.png 685 Changed
Shimmer.Custom elements.chromium.png 685 Changed
Shimmer.Data loaded.chromium.png 685 Changed
Signals 21 screenshots
Image Name Diff(in Pixels) Image Type
Signals.Awaiting approval.chromium.png 2993 Changed
Signals.Blocked.chromium.png 2993 Changed
Signals.Read-only.chromium.png 2993 Changed
Signals.Comments (count).chromium.png 2993 Changed
Signals.Comments.chromium.png 2993 Changed
Signals.Emailed.chromium.png 2993 Changed
Signals.Malware detected.chromium.png 2993 Changed
Signals.Missing metadata.chromium.png 2993 Changed
Signals.Follow.chromium.png 2993 Changed
Signals.NotFollow.chromium.png 2993 Changed
Signals.New (positioning).chromium.png 2993 Changed
Signals.Mention.chromium.png 2993 Changed
Signals.Record.chromium.png 2993 Changed
Signals.New.chromium.png 2993 Changed
Signals.Trending.chromium.png 2993 Changed
Signals.Shared.chromium.png 2993 Changed
Signals.Someone checked out.chromium.png 2993 Changed
Signals.Unseen edit.chromium.png 2993 Changed
Signals.Unseen reply.chromium.png 2993 Changed
Signals.You checked out.chromium.png 2993 Changed
Signals.Warning.chromium.png 2993 Changed
Slider 7 screenshots
Image Name Diff(in Pixels) Image Type
Slider.Max not multiple of step.chromium.png 3487 Changed
Slider.Vertical.chromium.png 3487 Changed
Slider.Disabled.chromium.png 3487 Changed
Slider.Step less than 1.chromium.png 3487 Changed
Slider.EqualMinMax.chromium.png 3487 Changed
Slider.Root.chromium.png 3487 Changed
Slider.Root RTL.chromium.png 4177 Changed
Spinner 8 screenshots
Image Name Diff(in Pixels) Image Type
Spinner.Extra small.chromium.png 714 Changed
Spinner.Medium.chromium.png 714 Changed
Spinner.Label.chromium.png 714 Changed
Spinner.Large.chromium.png 714 Changed
Spinner.Label on the left.chromium.png 714 Changed
Spinner.Label on the right.chromium.png 714 Changed
Spinner.Small.chromium.png 714 Changed
Spinner.Label at top.chromium.png 714 Changed
Stack 44 screenshots
Image Name Diff(in Pixels) Image Type
Stack.Horizontal Stack - Bottom-aligned.chromium.png 1020 Changed
Stack.Horizontal Stack - Default.chromium.png 1020 Changed
Stack.Horizontal Stack - Box shadow around items.chromium.png 1020 Changed
Stack.Horizontal Stack - Horizontally centered.chromium.png 1020 Changed
Stack.Horizontal Stack - Gap.chromium.png 1020 Changed
Stack.Horizontal Stack - Item alignments.chromium.png 828 Changed
Stack.Horizontal Stack - Right-aligned.chromium.png 1020 Changed
Stack.Horizontal Stack - Growing items.chromium.png 828 Changed
Stack.Horizontal Stack - Padding.chromium.png 1020 Changed
Stack.Horizontal Stack - Space around.chromium.png 1020 Changed
Stack.Horizontal Stack - Reversed.chromium.png 1020 Changed
Stack.Horizontal Stack - Space between.chromium.png 1020 Changed
Stack.Horizontal Stack - Vertically centered.chromium.png 1020 Changed
Stack.Horizontal Stack - Wrap with specified vertical gap.chromium.png 1020 Changed
Stack.Horizontal Stack - Shrinking items.chromium.png 828 Changed
Stack.Horizontal Stack - Space evenly.chromium.png 1020 Changed
Stack.Horizontal Stack Default RTL.chromium.png 1023 Changed
Stack.Horizontal Stack - Wrap.chromium.png 1020 Changed
Stack.Horizontal Stack Item Alignments RTL.chromium.png 832 Changed
Stack.Horizontal Stack Reversed RTL.chromium.png 1023 Changed
Stack.Horizontal Stack Wrap RTL.chromium.png 1023 Changed
Stack.Horizontal Stack Gap RTL.chromium.png 1023 Changed
Stack.Horizontal Stack Right Aligned RTL.chromium.png 1023 Changed
Stack.Vertical Stack - Bottom-aligned.chromium.png 1020 Changed
Stack.Vertical Stack - Default.chromium.png 1020 Changed
Stack.Vertical Stack - Box shadow around items.chromium.png 1020 Changed
Stack.Vertical Stack - Gap.chromium.png 1020 Changed
Stack.Vertical Stack - Item alignments.chromium.png 828 Changed
Stack.Vertical Stack - Horizontally centered.chromium.png 1020 Changed
Stack.Vertical Stack - Padding.chromium.png 1020 Changed
Stack.Vertical Stack - Growing items.chromium.png 828 Changed
Stack.Vertical Stack - Space evenly.chromium.png 1020 Changed
Stack.Vertical Stack - Reversed.chromium.png 1020 Changed
Stack.Vertical Stack Item Alignments RTL.chromium.png 832 Changed
Stack.Vertical Stack - Right-aligned.chromium.png 1020 Changed
Stack.Vertical Stack - Vertically centered.chromium.png 1020 Changed
Stack.Vertical Stack - Wrap.chromium.png 1020 Changed
Stack.Vertical Stack - Shrinking items.chromium.png 828 Changed
Stack.Vertical Stack - Space between.chromium.png 1020 Changed
Stack.Vertical Stack - Space around.chromium.png 1020 Changed
Stack.Vertical Stack Reversed RTL.chromium.png 1023 Changed
Stack.Vertical Stack Default RTL.chromium.png 1023 Changed
Stack.Vertical Stack Wrap RTL.chromium.png 1023 Changed
Stack.Vertical Stack Right Aligned RTL.chromium.png 1023 Changed
TextField 20 screenshots
Image Name Diff(in Pixels) Image Type
TextField.Error RTL.chromium.png 2716 Changed
TextField.Error.chromium.png 2013 Changed
TextField.Disabled.chromium.png 2013 Changed
TextField.Borderless.chromium.png 2013 Changed
TextField.Icon RTL.chromium.png 2716 Changed
TextField.Icon.chromium.png 2013 Changed
TextField.Multiline.chromium.png 2013 Changed
TextField.Multiline RTL.chromium.png 2716 Changed
TextField.Placeholder.chromium.png 2013 Changed
TextField.Multiline nonresizable.chromium.png 2013 Changed
TextField.Placeholder RTL.chromium.png 2716 Changed
TextField.Prefix With Value Disabled And Prefix Style Override RTL.chromium.png 2716 Changed
TextField.Prefix with Value, Disabled, and Prefix Style-Override.chromium.png 2013 Changed
TextField.Prefix With Value Disabled RTL.chromium.png 2716 Changed
TextField.Prefix with Value, Disabled.chromium.png 2013 Changed
TextField.Root.chromium.png 2013 Changed
TextField.Required.chromium.png 2013 Changed
TextField.Suffix RTL.chromium.png 2716 Changed
TextField.Suffix.chromium.png 2013 Changed
TextField.Underlined.chromium.png 2013 Changed
Tile 5 screenshots
Image Name Diff(in Pixels) Image Type
Tile.Document tile with fit landscape image.chromium.png 2993 Changed
Tile.Tile with no content and long text.chromium.png 2993 Changed
Tile.Document tile with fit portrait image.chromium.png 2993 Changed
Tile.Document tile with icon.chromium.png 2993 Changed
Tile.Document tile with icon-sized image.chromium.png 2993 Changed
Toggle 12 screenshots
Image Name Diff(in Pixels) Image Type
Toggle.Checked RTL.chromium.png 855 Changed
Toggle.With inline label (JSX Element) and without onText and offText.chromium.png 857 Changed
Toggle.Unchecked RTL.chromium.png 855 Changed
Toggle.Unchecked.chromium.png 857 Changed
Toggle.Disabled checked.chromium.png 857 Changed
Toggle.With inline label (JSX Element).chromium.png 857 Changed
Toggle.Checked.chromium.png 857 Changed
Toggle.With inline label and without onText and offText.chromium.png 857 Changed
Toggle.Disabled unchecked.chromium.png 857 Changed
Toggle.With inline label disabled.chromium.png 857 Changed
Toggle.With inline label disabled and without onText and offText.chromium.png 857 Changed
Toggle.With inline label.chromium.png 857 Changed
Tooltip 1 screenshots
Image Name Diff(in Pixels) Image Type
Tooltip.Default.chromium.png 3170 Changed
Tooltip - Multiple 1 screenshots
Image Name Diff(in Pixels) Image Type
Tooltip - Multiple.Two Tooltips.chromium.png 3112 Changed
react-charting-VerticalBarChart 1 screenshots
Image Name Diff(in Pixels) Image Type
react-charting-VerticalBarChart.Basic - Secondary Y Axis.chromium.png 4 Changed

@fabricteam
Copy link
Collaborator

fabricteam commented Sep 9, 2024 •
edited
Loading

Perf Analysis (@fluentui/react)

No significant results to display.

All results

Scenario Render type Master Ticks PR Ticks Iterations Status
BaseButton mount 632 621 5000
Breadcrumb mount 1787 1706 1000
Checkbox mount 1723 1718 5000
CheckboxBase mount 1474 1496 5000
ChoiceGroup mount 2966 2998 5000
ComboBox mount 687 702 1000
CommandBar mount 6708 6687 1000
ContextualMenu mount 14806 15007 1000
DefaultButton mount 800 792 5000
DetailsRow mount 2256 2200 5000
DetailsRowFast mount 2249 2289 5000
DetailsRowNoStyles mount 2090 2100 5000
Dialog mount 2823 2686 1000
DocumentCardTitle mount 233 238 1000
Dropdown mount 2039 1989 5000
FocusTrapZone mount 1160 1157 5000
FocusZone mount 1089 1105 5000
GroupedList mount 42611 43457 2
GroupedList virtual-rerender 20843 20830 2
GroupedList virtual-rerender-with-unmount 52663 54371 2
GroupedListV2 mount 220 243 2
GroupedListV2 virtual-rerender 221 221 2
GroupedListV2 virtual-rerender-with-unmount 227 221 2
IconButton mount 1148 1160 5000
Label mount 348 342 5000
Layer mount 2827 2768 5000
Link mount 416 393 5000
MenuButton mount 994 988 5000
MessageBar mount 22399 22292 5000
Nav mount 2047 2088 1000
OverflowSet mount 803 824 5000
Panel mount 1874 1827 1000
Persona mount 753 751 1000
Pivot mount 912 913 1000
PrimaryButton mount 948 972 5000
Rating mount 4806 4834 5000
SearchBox mount 944 922 5000
Shimmer mount 1893 1856 5000
Slider mount 1370 1379 5000
SpinButton mount 3049 2973 5000
Spinner mount 419 399 5000
SplitButton mount 1881 1894 5000
Stack mount 440 431 5000
StackWithIntrinsicChildren mount 893 880 5000
StackWithTextChildren mount 2820 2796 5000
SwatchColorPicker mount 6718 6591 5000
TagPicker mount 1559 1541 5000
Text mount 387 394 5000
TextField mount 995 997 5000
ThemeProvider mount 853 876 5000
ThemeProvider virtual-rerender 596 612 5000
ThemeProvider virtual-rerender-with-unmount 1312 1334 5000
Toggle mount 644 617 5000
buttonNative mount 203 202 5000

@spmonahan
fix: remove circular dependencies in shadow DOM code path
56df28f 
This fixes issues for AMD module loaders.
@spmonahan spmonahan marked this pull request as ready for review September 25, 2024 17:45
@spmonahan spmonahan requested a review from a team as a code owner September 25, 2024 17:45
@spmonahan spmonahan closed this Sep 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabricteam fabricteam fabricteam left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
September Project Cycle Q3 2024
Development

Successfully merging this pull request may close these issues.
2 participants
@spmonahan @fabricteam