Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RTL FIXES #32828

Merged
merged 3 commits into from
Sep 22, 2024
Merged

RTL FIXES #32828

merged 3 commits into from
Sep 22, 2024

Conversation

Anush2303
Copy link

Previous Behavior

New Behavior

Related Issue(s)

  • Fixes #

@Anush2303 Anush2303 marked this pull request as ready for review September 13, 2024 08:03
@Anush2303 Anush2303 requested a review from a team as a code owner September 13, 2024 08:03
@@ -242,12 +242,12 @@ export const VCBasic = () => {
lineLegendText={'just line'}
lineLegendColor={'brown'}
lineOptions={lineOptions}
{...(isCalloutselected && {
/*{...(isCalloutselected && {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why disabled this

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Custom callout is not working. Needs to be fixed.

Copy link
Contributor

@AtishayMsft AtishayMsft Sep 13, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

create a task about this and let it be enabled in the example.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay

enableReflow={true}
/>
</div>
<VerticalBarChart
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why removed div container

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will revert this. Probably had been trying something

@Anush2303 Anush2303 merged commit e389a7c into usr/atisjai/chartsV9 Sep 22, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants