Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: migrate to nx 19.7 #32830

Merged
merged 10 commits into from
Sep 23, 2024
Merged

chore: migrate to nx 19.7 #32830

merged 10 commits into from
Sep 23, 2024

Conversation

Hotell
Copy link
Contributor

@Hotell Hotell commented Sep 13, 2024 •
edited
Loading

Previous Behavior

New Behavior

Highlights:

NX Graph fixes/improvements

Better graph resolution exposed incorrect behaviours within our prepare-initial-release generator, which was trying to obtain graph after renames of projects ( which was incorrect ). Latest nx version exposed this issue and this PR fixes that by changing the order of execution of renaming related logic.

Jest Deprecated assertion api replacement

  • nx migration bumped @types/jest which exposed DEPRECATED apis usage within our codebase - this PR mitigates these violations

Related Issue(s)

@fabricteam
Copy link
Collaborator

fabricteam commented Sep 13, 2024 •
edited
Loading

🕵 fluentui-web-components-v3 No visual regressions between this PR and main

@fabricteam
Copy link
Collaborator

fabricteam commented Sep 13, 2024 •
edited
Loading

🕵 FluentUIV0 No visual regressions between this PR and main

@fabricteam
Copy link
Collaborator

fabricteam commented Sep 13, 2024 •
edited
Loading

Perf Analysis (@fluentui/react-components)

No significant results to display.

All results

Scenario Render type Master Ticks PR Ticks Iterations Status
Avatar mount 620 633 5000
Button mount 302 312 5000
Field mount 1147 1166 5000
FluentProvider mount 718 699 5000
FluentProviderWithTheme mount 84 84 10
FluentProviderWithTheme virtual-rerender 30 33 10
FluentProviderWithTheme virtual-rerender-with-unmount 80 69 10
MakeStyles mount 859 858 50000
Persona mount 1767 1711 5000
SpinButton mount 1377 1364 5000
SwatchPicker mount 1642 1673 5000

@fabricteam
Copy link
Collaborator

fabricteam commented Sep 13, 2024 •
edited
Loading

Perf Analysis (@fluentui/react-northstar)

Perf tests with no regressions
Scenario Current PR Ticks Baseline Ticks Ratio
AvatarMinimalPerf.default 120 102 1.18:1
AttachmentMinimalPerf.default 90 77 1.17:1
ButtonMinimalPerf.default 95 84 1.13:1
AnimationMinimalPerf.default 313 285 1.1:1
DropdownManyItemsPerf.default 403 371 1.09:1
TreeWith60ListItems.default 91 84 1.08:1
ChatDuplicateMessagesPerf.default 161 150 1.07:1
ReactionMinimalPerf.default 220 206 1.07:1
AlertMinimalPerf.default 155 146 1.06:1
CarouselMinimalPerf.default 269 254 1.06:1
GridMinimalPerf.default 205 194 1.06:1
LabelMinimalPerf.default 222 209 1.06:1
RadioGroupMinimalPerf.default 270 254 1.06:1
SkeletonMinimalPerf.default 205 193 1.06:1
ChatMinimalPerf.default 444 424 1.05:1
ImageMinimalPerf.default 220 210 1.05:1
ListMinimalPerf.default 333 318 1.05:1
LoaderMinimalPerf.default 200 190 1.05:1
PopupMinimalPerf.default 366 349 1.05:1
PortalMinimalPerf.default 90 86 1.05:1
ProviderMinimalPerf.default 210 201 1.04:1
RefMinimalPerf.default 112 108 1.04:1
SegmentMinimalPerf.default 203 195 1.04:1
TextAreaMinimalPerf.default 292 280 1.04:1
TreeMinimalPerf.default 500 480 1.04:1
AttachmentSlotsPerf.default 635 615 1.03:1
CheckboxMinimalPerf.default 1143 1114 1.03:1
ItemLayoutMinimalPerf.default 736 712 1.03:1
TextMinimalPerf.default 196 191 1.03:1
ButtonSlotsPerf.default 324 318 1.02:1
DropdownMinimalPerf.default 1436 1403 1.02:1
InputMinimalPerf.default 524 516 1.02:1
LayoutMinimalPerf.default 200 197 1.02:1
ListWith60ListItems.default 378 370 1.02:1
IconMinimalPerf.default 385 377 1.02:1
TableManyItemsPerf.default 1112 1087 1.02:1
ToolbarMinimalPerf.default 537 527 1.02:1
DatepickerMinimalPerf.default 3598 3573 1.01:1
DialogMinimalPerf.default 447 443 1.01:1
EmbedMinimalPerf.default 1872 1862 1.01:1
FlexMinimalPerf.default 152 151 1.01:1
MenuMinimalPerf.default 514 511 1.01:1
RosterPerf.default 1595 1583 1.01:1
BoxMinimalPerf.default 196 196 1:1
ButtonOverridesMissPerf.default 643 641 1:1
DividerMinimalPerf.default 208 207 1:1
ProviderMergeThemesPerf.default 649 649 1:1
TableMinimalPerf.default 228 229 1:1
VideoMinimalPerf.default 430 428 1:1
HeaderMinimalPerf.default 200 202 0.99:1
ListNestedPerf.default 322 325 0.99:1
MenuButtonMinimalPerf.default 958 970 0.99:1
CustomToolbarPrototype.default 1447 1469 0.99:1
CardMinimalPerf.default 293 298 0.98:1
SliderMinimalPerf.default 712 726 0.98:1
SplitButtonMinimalPerf.default 2257 2303 0.98:1
StatusMinimalPerf.default 385 393 0.98:1
HeaderSlotsPerf.default 460 472 0.97:1
ListCommonPerf.default 378 391 0.97:1
ChatWithPopoverPerf.default 192 202 0.95:1
TooltipMinimalPerf.default 1227 1295 0.95:1
FormMinimalPerf.default 216 232 0.93:1
AccordionMinimalPerf.default 83 93 0.89:1

@fabricteam
Copy link
Collaborator

fabricteam commented Sep 13, 2024 •
edited
Loading

📊 Bundle size report

✅ No changes found

@fabricteam
Copy link
Collaborator

fabricteam commented Sep 13, 2024 •
edited
Loading

Perf Analysis (@fluentui/react)

No significant results to display.

All results

Scenario Render type Master Ticks PR Ticks Iterations Status
BaseButton mount 625 646 5000
Breadcrumb mount 1689 1768 1000
Checkbox mount 1710 1699 5000
CheckboxBase mount 1483 1490 5000
ChoiceGroup mount 2995 2935 5000
ComboBox mount 690 678 1000
CommandBar mount 6693 6647 1000
ContextualMenu mount 13656 13990 1000
DefaultButton mount 808 812 5000
DetailsRow mount 2235 2260 5000
DetailsRowFast mount 2280 2260 5000
DetailsRowNoStyles mount 2098 2030 5000
Dialog mount 2887 2794 1000
DocumentCardTitle mount 240 228 1000
Dropdown mount 1973 2016 5000
FocusTrapZone mount 1197 1210 5000
FocusZone mount 1089 1079 5000
GroupedList mount 42467 42586 2
GroupedList virtual-rerender 20603 20500 2
GroupedList virtual-rerender-with-unmount 52354 52427 2
GroupedListV2 mount 249 232 2
GroupedListV2 virtual-rerender 217 221 2
GroupedListV2 virtual-rerender-with-unmount 225 228 2
IconButton mount 1141 1141 5000
Label mount 344 358 5000
Layer mount 2768 2761 5000
Link mount 397 396 5000
MenuButton mount 987 1026 5000
MessageBar mount 21437 21517 5000
Nav mount 2062 2031 1000
OverflowSet mount 794 777 5000
Panel mount 1887 1899 1000
Persona mount 749 793 1000
Pivot mount 912 914 1000
PrimaryButton mount 951 938 5000
Rating mount 4722 4809 5000
SearchBox mount 937 948 5000
Shimmer mount 1969 1939 5000
Slider mount 1371 1354 5000
SpinButton mount 3003 2995 5000
Spinner mount 396 392 5000
SplitButton mount 1907 1892 5000
Stack mount 428 434 5000
StackWithIntrinsicChildren mount 879 889 5000
StackWithTextChildren mount 2810 2810 5000
SwatchColorPicker mount 6449 6421 5000
TagPicker mount 1456 1508 5000
Text mount 387 402 5000
TextField mount 956 949 5000
ThemeProvider mount 853 862 5000
ThemeProvider virtual-rerender 583 586 5000
ThemeProvider virtual-rerender-with-unmount 1310 1317 5000
Toggle mount 644 621 5000
buttonNative mount 190 194 5000

@Hotell
fixup! lint(react-conformance): mitigate deprecation warning exposed …
84b9d46 
…by latest jest types
@Hotell
fixup! fixup! lint(react-conformance): mitigate deprecation warning e…
53b2aeb 
…xposed by latest jest types
@Hotell
fixup! fixup! fixup! lint(react-conformance): mitigate deprecation wa…
2c340a4 
…rning exposed by latest jest types
@Hotell
fixup! fixup! fixup! fixup! lint(react-conformance): mitigate depreca…
4819fe7 
…tion warning exposed by latest jest types
@Hotell
fix(workspace-plugin): preprare-initial-release generator - update de…
b8a6251 
…pendants on preview package first when executing stable release migration
@Hotell
fixup! fixup! fixup! fixup! fixup! lint(react-conformance): mitigate …
b17a620 
…deprecation warning exposed by latest jest types
@Hotell
fixup! fixup! fixup! fixup! fixup! fixup! lint(react-conformance): mi…
4883c0d 
…tigate deprecation warning exposed by latest jest types
@Hotell
fixup! fixup! fixup! fixup! fixup! fixup! fixup! lint(react-conforman…
b4f5c41 
…ce): mitigate deprecation warning exposed by latest jest types
@Hotell Hotell marked this pull request as ready for review September 16, 2024 10:57
@Hotell Hotell requested a review from a team as a code owner September 16, 2024 10:57
@Hotell Hotell merged commit c414d2c into microsoft:master Sep 23, 2024
23 checks passed
@Hotell Hotell deleted the nx/migrate/19_7 branch September 23, 2024 14:57
@Mitch-At-Work Mitch-At-Work mentioned this pull request Sep 23, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabricteam fabricteam fabricteam left review comments

@layershifter layershifter layershifter approved these changes

@mainframev mainframev mainframev approved these changes

@TristanWatanabe TristanWatanabe TristanWatanabe approved these changes

@behowell behowell Awaiting requested review from behowell behowell is a code owner

@spmonahan spmonahan Awaiting requested review from spmonahan spmonahan is a code owner

@khmakoto khmakoto Awaiting requested review from khmakoto khmakoto is a code owner

Assignees
No one assigned
Labels
Area: Build System NX: core
Projects
None yet
Milestone
September Project Cycle Q3 2024
Development

Successfully merging this pull request may close these issues.

[Bug]: Stable script broken once component stories are added
5 participants
@Hotell @fabricteam @TristanWatanabe @mainframev @layershifter