refactor(motion): refactor Collapse and variant functions #32833
+403
−114
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robertpenner
force-pushed
the
feat/collapse-refactor
branch
from
5094245
to
666992b
Compare
📊 Bundle size report✅ No changes found |
Perf Analysis (
|
| Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
|---|---|---|---|---|---|
| Avatar | mount | 643 | 632 | 5000 | |
| Button | mount | 305 | 309 | 5000 | |
| Field | mount | 1131 | 1138 | 5000 | |
| FluentProvider | mount | 734 | 716 | 5000 | |
| FluentProviderWithTheme | mount | 85 | 81 | 10 | |
| FluentProviderWithTheme | virtual-rerender | 36 | 37 | 10 | |
| FluentProviderWithTheme | virtual-rerender-with-unmount | 67 | 77 | 10 | |
| MakeStyles | mount | 860 | 870 | 50000 | |
| Persona | mount | 1759 | 1709 | 5000 | |
| SpinButton | mount | 1353 | 1376 | 5000 | |
| SwatchPicker | mount | 1648 | 1659 | 5000 |
fabricteam
reviewed
Sep 13, 2024
...react-components/react-motion-components-preview/library/src/components/Collapse/Collapse.ts
Show resolved
Hide resolved
robertpenner
force-pushed
the
feat/collapse-refactor
branch
8 times, most recently
from
942ed60
to
91914a6
Compare
- revert Toast from Collapse back to ToastContainerMotion - auto-collapse implementation is saved in another branch
…ce PR size - saved in another branch
robertpenner
force-pushed
the
feat/collapse-refactor
branch
from
af0003b
to
43a9079
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previous Behavior
New Behavior
Related Issue(s)