-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(Menu): Do not rely on tabster restorer for focus restore #32840
Merged
ling1726
merged 4 commits into
microsoft:master
from
ling1726:react-menu/fix/stop-restorer
Sep 23, 2024
Merged
fix(Menu): Do not rely on tabster restorer for focus restore #32840
ling1726
merged 4 commits into
microsoft:master
from
ling1726:react-menu/fix/stop-restorer
Sep 23, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
📊 Bundle size reportUnchanged fixtures
|
Perf Analysis (
|
Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
---|---|---|---|---|---|
FluentProviderWithTheme | virtual-rerender | 35 | 37 | 10 | Possible regression |
All results
Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
---|---|---|---|---|---|
Avatar | mount | 652 | 626 | 5000 | |
Button | mount | 292 | 319 | 5000 | |
Field | mount | 1128 | 1149 | 5000 | |
FluentProvider | mount | 716 | 724 | 5000 | |
FluentProviderWithTheme | mount | 84 | 93 | 10 | |
FluentProviderWithTheme | virtual-rerender | 35 | 37 | 10 | Possible regression |
FluentProviderWithTheme | virtual-rerender-with-unmount | 80 | 87 | 10 | |
MakeStyles | mount | 879 | 890 | 50000 | |
Persona | mount | 1781 | 1778 | 5000 | |
SpinButton | mount | 1381 | 1413 | 5000 | |
SwatchPicker | mount | 1666 | 1635 | 5000 |
fabricteam
reviewed
Sep 16, 2024
layershifter
approved these changes
Sep 23, 2024
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The restorer can cause unintended focus switching whenever other restore sources lose focus to body. In internal discussions with @jurokapsiar we decided that it would be better to allow lost focus to body in applications rather than unexpected focus switches.
There are no changes to Popover or Dialog because those previously used
Deloser
as a part of attributes and there was never imperative focus restore on those componentsPrevious Behavior
The Menu used Tabster
Restorer
API to restore focus to the triggerNew Behavior
Reverts Menu to restore focus manually pre - #28530. However the restorer source is still kept on the
MenuPopover
to make sure that users can still useMenu
without a trigger easily.