feat(eslint-rules): implement no-missing-jsx-pragma in order to automate and unify slot API usage
#32842
+300
−26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…roper ts-eslint types resolution
🕵 fluentui-web-components-v3 No visual regressions between this PR and main |
Perf Analysis (
|
| Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
|---|---|---|---|---|---|
| Avatar | mount | 654 | 625 | 5000 | |
| Button | mount | 299 | 306 | 5000 | |
| Field | mount | 1152 | 1094 | 5000 | |
| FluentProvider | mount | 699 | 712 | 5000 | |
| FluentProviderWithTheme | mount | 84 | 85 | 10 | |
| FluentProviderWithTheme | virtual-rerender | 33 | 39 | 10 | |
| FluentProviderWithTheme | virtual-rerender-with-unmount | 79 | 76 | 10 | |
| MakeStyles | mount | 879 | 870 | 50000 | |
| Persona | mount | 1800 | 1768 | 5000 | |
| SpinButton | mount | 1398 | 1414 | 5000 | |
| SwatchPicker | mount | 1628 | 1699 | 5000 |
fabricteam
reviewed
Sep 16, 2024
| @@ -0,0 +1,7 @@ | |||
| { | |||
There was a problem hiding this comment.
🕵🏾♀️ visual regressions to review in the fluentuiv8 Visual Regression Report
react-charting-VerticalBarChart 1 screenshots
| Image Name | Diff(in Pixels) | Image Type |
|---|---|---|
| react-charting-VerticalBarChart.Basic - Secondary Y Axis.chromium.png | 4 | Changed |
🕵 FluentUIV0 No visual regressions between this PR and main |
📊 Bundle size report✅ No changes found |
fabricteam
reviewed
Sep 16, 2024
| @@ -0,0 +1,7 @@ | |||
| { | |||
There was a problem hiding this comment.
🕵🏾♀️ visual regressions to review in the fluentuiv9 Visual Regression Report
Avatar Converged 3 screenshots
| Image Name | Diff(in Pixels) | Image Type |
|---|---|---|
| Avatar Converged.size+inactive+badge.chromium.png | 1 | Changed |
| Avatar Converged.Badge Mask RTL.chromium.png | 3 | Changed |
| Avatar Converged.badgeMask.chromium.png | 11 | Changed |
Drawer 2 screenshots
| Image Name | Diff(in Pixels) | Image Type |
|---|---|---|
| Drawer.overlay drawer full.chromium.png | 2863 | Changed |
| Drawer.Full Overlay Dark Mode.chromium.png | 996 | Changed |
Perf Analysis (
|
| Scenario | Current PR Ticks | Baseline Ticks | Ratio |
|---|---|---|---|
| AlertMinimalPerf.default | 166 | 146 | 1.14:1 |
| ChatDuplicateMessagesPerf.default | 169 | 152 | 1.11:1 |
| AvatarMinimalPerf.default | 117 | 106 | 1.1:1 |
| BoxMinimalPerf.default | 208 | 189 | 1.1:1 |
| FormMinimalPerf.default | 236 | 214 | 1.1:1 |
| SegmentMinimalPerf.default | 213 | 194 | 1.1:1 |
| ButtonMinimalPerf.default | 98 | 90 | 1.09:1 |
| ListNestedPerf.default | 334 | 310 | 1.08:1 |
| TextAreaMinimalPerf.default | 307 | 288 | 1.07:1 |
| CarouselMinimalPerf.default | 266 | 252 | 1.06:1 |
| ChatWithPopoverPerf.default | 201 | 189 | 1.06:1 |
| ReactionMinimalPerf.default | 223 | 211 | 1.06:1 |
| LayoutMinimalPerf.default | 207 | 198 | 1.05:1 |
| ListCommonPerf.default | 404 | 386 | 1.05:1 |
| PortalMinimalPerf.default | 92 | 88 | 1.05:1 |
| SkeletonMinimalPerf.default | 200 | 191 | 1.05:1 |
| GridMinimalPerf.default | 198 | 190 | 1.04:1 |
| HeaderSlotsPerf.default | 473 | 455 | 1.04:1 |
| ItemLayoutMinimalPerf.default | 727 | 699 | 1.04:1 |
| TreeMinimalPerf.default | 497 | 478 | 1.04:1 |
| ListWith60ListItems.default | 383 | 372 | 1.03:1 |
| ProviderMergeThemesPerf.default | 668 | 646 | 1.03:1 |
| TooltipMinimalPerf.default | 1299 | 1266 | 1.03:1 |
| AccordionMinimalPerf.default | 85 | 83 | 1.02:1 |
| CardMinimalPerf.default | 329 | 321 | 1.02:1 |
| InputMinimalPerf.default | 549 | 537 | 1.02:1 |
| LabelMinimalPerf.default | 219 | 214 | 1.02:1 |
| RosterPerf.default | 1617 | 1592 | 1.02:1 |
| ProviderMinimalPerf.default | 209 | 204 | 1.02:1 |
| RadioGroupMinimalPerf.default | 265 | 261 | 1.02:1 |
| ToolbarMinimalPerf.default | 553 | 542 | 1.02:1 |
| VideoMinimalPerf.default | 446 | 438 | 1.02:1 |
| DropdownManyItemsPerf.default | 401 | 397 | 1.01:1 |
| EmbedMinimalPerf.default | 1884 | 1874 | 1.01:1 |
| MenuMinimalPerf.default | 500 | 496 | 1.01:1 |
| PopupMinimalPerf.default | 355 | 352 | 1.01:1 |
| RefMinimalPerf.default | 113 | 112 | 1.01:1 |
| TextMinimalPerf.default | 196 | 194 | 1.01:1 |
| ButtonSlotsPerf.default | 316 | 317 | 1:1 |
| DatepickerMinimalPerf.default | 3628 | 3618 | 1:1 |
| DialogMinimalPerf.default | 455 | 455 | 1:1 |
| DividerMinimalPerf.default | 210 | 209 | 1:1 |
| DropdownMinimalPerf.default | 1428 | 1429 | 1:1 |
| HeaderMinimalPerf.default | 206 | 206 | 1:1 |
| SliderMinimalPerf.default | 753 | 751 | 1:1 |
| CustomToolbarPrototype.default | 1481 | 1475 | 1:1 |
| CheckboxMinimalPerf.default | 1128 | 1139 | 0.99:1 |
| ImageMinimalPerf.default | 227 | 229 | 0.99:1 |
| SplitButtonMinimalPerf.default | 2269 | 2285 | 0.99:1 |
| IconMinimalPerf.default | 383 | 387 | 0.99:1 |
| TableManyItemsPerf.default | 1087 | 1098 | 0.99:1 |
| TreeWith60ListItems.default | 88 | 89 | 0.99:1 |
| ButtonOverridesMissPerf.default | 650 | 663 | 0.98:1 |
| ChatMinimalPerf.default | 444 | 451 | 0.98:1 |
| ListMinimalPerf.default | 310 | 316 | 0.98:1 |
| AttachmentMinimalPerf.default | 88 | 91 | 0.97:1 |
| FlexMinimalPerf.default | 153 | 157 | 0.97:1 |
| MenuButtonMinimalPerf.default | 964 | 994 | 0.97:1 |
| TableMinimalPerf.default | 235 | 242 | 0.97:1 |
| AttachmentSlotsPerf.default | 636 | 665 | 0.96:1 |
| AnimationMinimalPerf.default | 291 | 306 | 0.95:1 |
| LoaderMinimalPerf.default | 185 | 195 | 0.95:1 |
| StatusMinimalPerf.default | 386 | 415 | 0.93:1 |
Perf Analysis (
|
| Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
|---|---|---|---|---|---|
| BaseButton | mount | 635 | 619 | 5000 | |
| Breadcrumb | mount | 1675 | 1672 | 1000 | |
| Checkbox | mount | 1688 | 1709 | 5000 | |
| CheckboxBase | mount | 1477 | 1475 | 5000 | |
| ChoiceGroup | mount | 2928 | 2953 | 5000 | |
| ComboBox | mount | 679 | 672 | 1000 | |
| CommandBar | mount | 6536 | 6565 | 1000 | |
| ContextualMenu | mount | 11716 | 11710 | 1000 | |
| DefaultButton | mount | 787 | 799 | 5000 | |
| DetailsRow | mount | 2230 | 2257 | 5000 | |
| DetailsRowFast | mount | 2213 | 2211 | 5000 | |
| DetailsRowNoStyles | mount | 2053 | 2038 | 5000 | |
| Dialog | mount | 2822 | 2838 | 1000 | |
| DocumentCardTitle | mount | 212 | 223 | 1000 | |
| Dropdown | mount | 1965 | 1995 | 5000 | |
| FocusTrapZone | mount | 1170 | 1172 | 5000 | |
| FocusZone | mount | 1085 | 1096 | 5000 | |
| GroupedList | mount | 42160 | 42243 | 2 | |
| GroupedList | virtual-rerender | 20308 | 20569 | 2 | |
| GroupedList | virtual-rerender-with-unmount | 51790 | 52088 | 2 | |
| GroupedListV2 | mount | 224 | 228 | 2 | |
| GroupedListV2 | virtual-rerender | 218 | 230 | 2 | |
| GroupedListV2 | virtual-rerender-with-unmount | 224 | 230 | 2 | |
| IconButton | mount | 1128 | 1129 | 5000 | |
| Label | mount | 340 | 354 | 5000 | |
| Layer | mount | 2740 | 2726 | 5000 | |
| Link | mount | 404 | 392 | 5000 | |
| MenuButton | mount | 994 | 972 | 5000 | |
| MessageBar | mount | 21124 | 21227 | 5000 | |
| Nav | mount | 2053 | 2041 | 1000 | |
| OverflowSet | mount | 793 | 778 | 5000 | |
| Panel | mount | 1778 | 1882 | 1000 | |
| Persona | mount | 752 | 746 | 1000 | |
| Pivot | mount | 923 | 912 | 1000 | |
| PrimaryButton | mount | 937 | 921 | 5000 | |
| Rating | mount | 4711 | 4750 | 5000 | |
| SearchBox | mount | 935 | 912 | 5000 | |
| Shimmer | mount | 1915 | 1909 | 5000 | |
| Slider | mount | 1355 | 1332 | 5000 | |
| SpinButton | mount | 2974 | 3028 | 5000 | |
| Spinner | mount | 393 | 403 | 5000 | |
| SplitButton | mount | 1894 | 1907 | 5000 | |
| Stack | mount | 412 | 421 | 5000 | |
| StackWithIntrinsicChildren | mount | 872 | 898 | 5000 | |
| StackWithTextChildren | mount | 2752 | 2765 | 5000 | |
| SwatchColorPicker | mount | 6314 | 6415 | 5000 | |
| TagPicker | mount | 1406 | 1463 | 5000 | |
| Text | mount | 403 | 382 | 5000 | |
| TextField | mount | 926 | 948 | 5000 | |
| ThemeProvider | mount | 847 | 886 | 5000 | |
| ThemeProvider | virtual-rerender | 577 | 578 | 5000 | |
| ThemeProvider | virtual-rerender-with-unmount | 1298 | 1292 | 5000 | |
| Toggle | mount | 607 | 622 | 5000 | |
| buttonNative | mount | 193 | 200 | 5000 |
Hotell
changed the title
no-missing-jsx-pragma in order to automate and unify slot API usage
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previous Behavior
New Behavior
Related Issue(s)